[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #836: audio nxstyle fixes and audio drivers cleanup

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #836:
URL: https://github.com/apache/incubator-nuttx/pull/836#discussion_r412272807



##########
File path: include/nuttx/audio/audio.h
##########
@@ -465,8 +480,8 @@ struct audio_buf_desc_s
   uint16_t            numbytes;           /* Number of bytes to allocate */
   union
   {
-    FAR struct ap_buffer_s  *pBuffer;     /* Buffer to free / enqueue */
-    FAR struct ap_buffer_s  **ppBuffer;   /* Pointer to receive allocated buffer */
+    FAR struct ap_buffer_s  *buffer;     /* Buffer to free / enqueue */
+    FAR struct ap_buffer_s  **pbuffer;   /* Pointer to receive allocated buffer */
   } u;
 };

Review comment:
       audio.h cannot be changed!  You cannot chanage audio.h without also changing all of the files that include audio.h.
   
   You will either have to remove the changes to this (and any other common header files), or modify all places where the header file is included.  That includes apps/examples/i2sloop/i2sloop_main.c
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org