You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Aleksei-grovety (via GitHub)" <gi...@apache.org> on 2023/03/28 09:25:12 UTC
[GitHub] [tvm] Aleksei-grovety opened a new pull request, #14414: [microTVM] Fix link to magic_wand model
Aleksei-grovety opened a new pull request, #14414:
URL: https://github.com/apache/tvm/pull/14414
Link to the model was replaced with a link before it was removed from the repositoryhttps://github.com/tensorflow/tflite-micro/commit/bef8fe8bc6183cc4e1ce852579abcb7a171f8a5c
cc @neildhickey, @lhutton1, @ekalda, @leandron, @ilyag-grovety
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1489908896
> LGTM, thanks! Just to double check, did you already upload the model to S3?
I didn't, someone uploaded [the model](https://tvm-ci-resources.s3.us-west-2.amazonaws.com/tensorflow/tflite-micro/raw/a56087ffa2703b4d5632f024a8a4c899815c31bb/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1487153283
@Aleksei-grovety could you please add the commit sha to the link so we avoid this issue in future? Also to update a link we need to also upload it in S3. I can help you with that if you post the link here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on a diff in pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on code in PR #14414:
URL: https://github.com/apache/tvm/pull/14414#discussion_r1150413445
##########
gallery/how_to/work_with_microtvm/micro_tvmc.sh:
##########
@@ -87,7 +87,7 @@ tvmc micro --help
# For this tutorial we will be using the model in tflite format.
#
# bash
-wget https://github.com/tensorflow/tflite-micro/raw/main/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
+wget https://github.com/tensorflow/tflite-micro/raw/1b68490dcfd087c308a1f8d14012ab1cb39c9ac0/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
Review Comment:
I'll update the example to use [micro_speech](https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite) as it's used in other examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1486513616
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @alanmacd, @gromero, @leandron, @mehrdadh, @mkatanbaf <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1491393950
Thanks @mehrdadh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FranklandJack commented on a diff in pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "FranklandJack (via GitHub)" <gi...@apache.org>.
FranklandJack commented on code in PR #14414:
URL: https://github.com/apache/tvm/pull/14414#discussion_r1150340455
##########
gallery/how_to/work_with_microtvm/micro_tvmc.sh:
##########
@@ -87,7 +87,7 @@ tvmc micro --help
# For this tutorial we will be using the model in tflite format.
#
# bash
-wget https://github.com/tensorflow/tflite-micro/raw/main/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
+wget https://github.com/tensorflow/tflite-micro/raw/1b68490dcfd087c308a1f8d14012ab1cb39c9ac0/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
Review Comment:
Thanks for the fix 😄 I wonder if we should update the example to use one of the currently listed upstream examples e.g. [micro speech](https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite).
Obviously this would be prone to the same error we have just seen if that model ever got removed, however it does avoid us having a reference to a random commit in this example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FranklandJack commented on a diff in pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "FranklandJack (via GitHub)" <gi...@apache.org>.
FranklandJack commented on code in PR #14414:
URL: https://github.com/apache/tvm/pull/14414#discussion_r1150692068
##########
gallery/how_to/work_with_microtvm/micro_tvmc.sh:
##########
@@ -87,7 +87,7 @@ tvmc micro --help
# For this tutorial we will be using the model in tflite format.
#
# bash
-wget https://github.com/tensorflow/tflite-micro/raw/main/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
+wget https://github.com/tensorflow/tflite-micro/raw/1b68490dcfd087c308a1f8d14012ab1cb39c9ac0/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
Review Comment:
Awesome, thank you 😄
I think we will also need to update references to `magic wand` [here](https://github.com/apache/tvm/blob/main/gallery/how_to/work_with_microtvm/micro_tvmc.sh#L84), [here](https://github.com/apache/tvm/blob/main/gallery/how_to/work_with_microtvm/micro_tvmc.sh#L103) and [here](https://github.com/apache/tvm/blob/main/gallery/how_to/work_with_microtvm/micro_tvmc.sh#L106).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1490554259
@Aleksei-grovety yeah I added it here: https://github.com/apache/tvm/actions/runs/4555724050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1488129737
> @Aleksei-grovety could you please add the commit sha to the link so we avoid this issue in future? Also to update a link we need to also upload it in S3. I can help you with that if you post the link here.
The link is https://github.com/tensorflow/tflite-micro/blob/a56087ffa2703b4d5632f024a8a4c899815c31bb/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite
I chose commit sha with the latest model changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "driazati (via GitHub)" <gi...@apache.org>.
driazati commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1489156813
Looks like Jenkins got stuck on something, I rebased this and added `[skip ci]` so we can get this merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14414:
URL: https://github.com/apache/tvm/pull/14414#issuecomment-1489148542
`skip-ci` is not working since the commit message doesn't start `skip-ci` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh merged PR #14414:
URL: https://github.com/apache/tvm/pull/14414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on a diff in pull request #14414: [microTVM] Fix link to magic_wand model
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on code in PR #14414:
URL: https://github.com/apache/tvm/pull/14414#discussion_r1150413445
##########
gallery/how_to/work_with_microtvm/micro_tvmc.sh:
##########
@@ -87,7 +87,7 @@ tvmc micro --help
# For this tutorial we will be using the model in tflite format.
#
# bash
-wget https://github.com/tensorflow/tflite-micro/raw/main/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
+wget https://github.com/tensorflow/tflite-micro/raw/1b68490dcfd087c308a1f8d14012ab1cb39c9ac0/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
Review Comment:
I'll update the example to use [micro speech](https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite) as it's used in other examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on a diff in pull request #14414: [skip ci] Replace magic_wand model with micro_speech
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on code in PR #14414:
URL: https://github.com/apache/tvm/pull/14414#discussion_r1151823295
##########
gallery/how_to/work_with_microtvm/micro_tvmc.sh:
##########
@@ -87,7 +87,7 @@ tvmc micro --help
# For this tutorial we will be using the model in tflite format.
#
# bash
-wget https://github.com/tensorflow/tflite-micro/raw/main/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
+wget https://github.com/tensorflow/tflite-micro/raw/1b68490dcfd087c308a1f8d14012ab1cb39c9ac0/tensorflow/lite/micro/examples/magic_wand/magic_wand.tflite
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org