You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/20 04:06:49 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #19095: Ensure task state doesn't change when marked as failed/success/skipped
ephraimbuddy opened a new pull request #19095:
URL: https://github.com/apache/airflow/pull/19095
Closes: https://github.com/apache/airflow/issues/16078
Currently, when a dagrun is marked as success in the UI, the expected
sigterm is sent but the task continues running, changing the dagrun to running
before eventually failing. Same as well when marked as failed.
Also, queued tasks continue running even when the dagrun was failed
The same thing happens when a dagrun times out. The tasks that are marked
skipped, starts again, and then fails.
This PR fixes these issues
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19095: Ensure task state doesn't change when marked as failed/success/skipped
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19095:
URL: https://github.com/apache/airflow/pull/19095#issuecomment-947625220
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #19095: Ensure task state doesn't change when marked as failed/success/skipped
Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged pull request #19095:
URL: https://github.com/apache/airflow/pull/19095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19095: Ensure task state doesn't change when marked as failed/success/skipped
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19095:
URL: https://github.com/apache/airflow/pull/19095#issuecomment-947313085
I'll add tests later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org