You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/04/08 00:16:42 UTC

svn commit: r1585606 - in /logging/log4j/log4j2/trunk: log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/ log4j-plugin-processor/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/

Author: mattsicker
Date: Mon Apr  7 22:16:42 2014
New Revision: 1585606

URL: http://svn.apache.org/r1585606
Log:
Add some TODO notes to self.

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/PluginManager.java
    logging/log4j/log4j2/trunk/log4j-plugin-processor/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/PluginManager.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/PluginManager.java?rev=1585606&r1=1585605&r2=1585606&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/PluginManager.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/PluginManager.java Mon Apr  7 22:16:42 2014
@@ -48,6 +48,7 @@ public class PluginManager {
 
     private static final long NANOS_PER_SECOND = 1000000000L;
 
+    // TODO: re-use PluginCache code from plugin processor
     private static ConcurrentMap<String, ConcurrentMap<String, PluginType<?>>> pluginTypeMap =
         new ConcurrentHashMap<String, ConcurrentMap<String, PluginType<?>>>();
 

Modified: logging/log4j/log4j2/trunk/log4j-plugin-processor/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-plugin-processor/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java?rev=1585606&r1=1585605&r2=1585606&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-plugin-processor/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java (original)
+++ logging/log4j/log4j2/trunk/log4j-plugin-processor/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java Mon Apr  7 22:16:42 2014
@@ -48,6 +48,8 @@ import static javax.tools.StandardLocati
 @SupportedSourceVersion(SourceVersion.RELEASE_6)
 public class PluginProcessor extends AbstractProcessor {
 
+    // TODO: this could be made more abstract to allow for compile-time and run-time plugin processing
+
     /**
      * Destination package for saving cache file.
      */