[jira] [Commented] (DRILL-6002) Avoid memory copy from direct buffer to heap while spilling to local disk

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271768#comment-16271768 ] 

ASF GitHub Bot commented on DRILL-6002:
---------------------------------------

GitHub user vrozov opened a pull request:

    https://github.com/apache/drill/pull/1058

    DRILL-6002: Avoid memory copy from direct buffer to heap while spilling to local disk

    @paul-rogers Please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vrozov/drill DRILL-6002

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1058
    
----
commit 8e9124de681d3a8cd70bf0bb243460cb78dcb295
Author: Vlad Rozov <vr...@apache.org>
Date:   2017-11-22T22:06:13Z

    DRILL-6002: Avoid memory copy from direct buffer to heap while spilling to local disk

----


> Avoid memory copy from direct buffer to heap while spilling to local disk
> -------------------------------------------------------------------------
>
>                 Key: DRILL-6002
>                 URL: https://issues.apache.org/jira/browse/DRILL-6002
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>
> When spilling to a local disk or to any file system that supports WritableByteChannel it is preferable to avoid copy from off-heap to java heap as WritableByteChannel can work directly with the off-heap memory.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)