You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 02:00:15 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #11937: Avoid to infinitely split bundle
Shoothzj opened a new pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937
### Motivation
If there is just one topic, but reached the split conditition. The pulsar broker will went to infinitely splitting bundle.
### Modifications
If there is just one topic, we do not split.
### Documentation
- [ ] no-need-doc
It's an internal change, no need doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#issuecomment-914021797
> I have one question:
> Why 1 and not a configurable threshold ? is it for developers / pulsar standalone users ?
First, It's not a config like `minBundleTopics`.
Second, it's not only for developer use, let's think a scene
One namespace, one topic/partition, but the topic's rate is high, the bundle split will infinitely splite bundle, make this topic doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#issuecomment-914438457
Good catch @Shoothzj !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#discussion_r703141942
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
##########
@@ -82,6 +82,11 @@ public BundleSplitterTask(final PulsarService pulsar) {
totalMessageRate = longTermData.totalMsgRate();
totalMessageThroughput = longTermData.totalMsgThroughput();
}
+ // if there are just one topic, avoid to infinitely split
+ if (stats.topics == 1) {
Review comment:
Could you please help add a test for covering the new change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#issuecomment-914026815
> why bundle contains one topic cannot split? I am confused.
Cause it will lead to infinitely split bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on a change in pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#discussion_r703356216
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
##########
@@ -82,6 +82,11 @@ public BundleSplitterTask(final PulsarService pulsar) {
totalMessageRate = longTermData.totalMsgRate();
totalMessageThroughput = longTermData.totalMsgThroughput();
}
+ // if there are just one topic, avoid to infinitely split
+ if (stats.topics == 1) {
Review comment:
addded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#issuecomment-914022014
> I have one question:
> Why 1 and not a configurable threshold ? is it for developers / pulsar standalone users ?
And it's meaningless for split bundle that has only one topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11937: Avoid to infinitely split bundle
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11937:
URL: https://github.com/apache/pulsar/pull/11937#issuecomment-914022082
why bundle contains one topic cannot split? I am confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org