[GitHub] [hive] pvary commented on a diff in pull request #3226: HIVE-26157: Change Iceberg storage handler authz URI to metadata location

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3226:
URL: https://github.com/apache/hive/pull/3226#discussion_r858361076


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -450,7 +452,9 @@ public boolean isValidMetadataTable(String metaTableName) {
   public URI getURIForAuth(org.apache.hadoop.hive.metastore.api.Table hmsTable) throws URISyntaxException {
     String dbName = hmsTable.getDbName();
     String tableName = hmsTable.getTableName();
-    return new URI(ICEBERG_URI_PREFIX + dbName + "/" + tableName);
+    Table table = IcebergTableUtil.getTable(conf, hmsTable);

Review Comment:
   What happens if we provide the `metadata_location` in the table properties when creating the table?
   Or do we plan to handle this in a different PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org