[GitHub] [solr] magibney commented on a diff in pull request #1205: SOLR-16569: Add java system property to overseer queue size

[GitBox <gi...@apache.org>]

magibney commented on code in PR #1205:
URL: https://github.com/apache/solr/pull/1205#discussion_r1039729084


##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -336,8 +337,8 @@ public void run() {
               for (Pair<String, byte[]> head : queue) {
                 byte[] data = head.second();
                 final ZkNodeProps message = ZkNodeProps.load(data);
-                if (log.isDebugEnabled()) {

Review Comment:
   I think if we're going to adjust log levels/output, that should be done as a separate issue/PR. At a minimum, if bundling the "configurable overseer queue size" change with log-level changes, it would make sense to re-title this (or even open a new) issue/PR to highlight the logging changes (which will affect everybody), perhaps even excluding entirely from the title the "configurability" change (which will essentially affect nobody, at least initially).
   
   Assuming that this logging is of particular interest for a specific use case, is there a reason to not simply adjust the log level via log configuration files (setting Overseer class log level to DEBUG)?
   
   >We just need to log once when the overseer starts up , not for every operation.
   
   This would substantially change the purpose of the logging already in place, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org