You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2012/07/24 16:26:23 UTC

svn commit: r1365079 - /subversion/trunk/tools/dev/gdb-py/svndbg/printers.py

Author: julianfoad
Date: Tue Jul 24 14:26:22 2012
New Revision: 1365079

URL: http://svn.apache.org/viewvc?rev=1365079&view=rev
Log:
Fix GDB pretty-printing of mergeinfo structures: don't use svn_rangelist_t
because currently there is no such type defined in Subversion.
* tools/dev/gdb-py/svndbg/printers.py
  (SvnMergeinfoPrinter): Use apr_array_header_t instead.
  (build_libsvn_printers): Don't register printers for 'svn_rangelist_t'
  types, although doing so doesn't actually cause a problem.

Modified:
    subversion/trunk/tools/dev/gdb-py/svndbg/printers.py

Modified: subversion/trunk/tools/dev/gdb-py/svndbg/printers.py
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dev/gdb-py/svndbg/printers.py?rev=1365079&r1=1365078&r2=1365079&view=diff
==============================================================================
--- subversion/trunk/tools/dev/gdb-py/svndbg/printers.py (original)
+++ subversion/trunk/tools/dev/gdb-py/svndbg/printers.py Tue Jul 24 14:26:22 2012
@@ -234,7 +234,8 @@ class SvnMergeinfoPrinter:
     """for svn_mergeinfo_t"""
     def __init__(self, val):
         self.hash_p = val
-        self.svn_rangelist_t = gdb.lookup_type('svn_rangelist_t')
+        # We don't actually have an svn_rangelist_t in Subversion...
+        self.svn_rangelist_t = gdb.lookup_type('apr_array_header_t')
 
     def to_string(self):
         if self.hash_p == 0:
@@ -341,10 +342,11 @@ def build_libsvn_printers():
                                 SvnMergeRangePrinter)
     libsvn_printer2.add_printer('svn_merge_range_t *', r'^svn_merge_range_t \*$',
                                 SvnMergeRangePrinter)
-    libsvn_printer2.add_printer('svn_rangelist_t', r'^svn_rangelist_t$',
-                                SvnRangelistPrinter)
-    libsvn_printer2.add_printer('svn_rangelist_t *', r'^svn_rangelist_t \*$',
-                                SvnRangelistPrinter)
+    # If we define an 'svn_rangelist_t' type in Subversion, we'll want these:
+    #libsvn_printer2.add_printer('svn_rangelist_t', r'^svn_rangelist_t$',
+    #                            SvnRangelistPrinter)
+    #libsvn_printer2.add_printer('svn_rangelist_t *', r'^svn_rangelist_t \*$',
+    #                            SvnRangelistPrinter)
     libsvn_printer2.add_printer('svn_mergeinfo_t', r'^svn_mergeinfo_t$',
                                 SvnMergeinfoPrinter)
     libsvn_printer2.add_printer('svn_mergeinfo_catalog_t', r'^svn_mergeinfo_catalog_t$',