You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Eelco Hillenius <ee...@gmail.com> on 2007/09/17 08:02:00 UTC
remove trace in Task?
This code:
if (log.isTraceEnabled())
{
log.trace("Run the job: " + code.toString());
}
in Task looks completely unnecessary to me. Left-over of some debugging?
Is anyone against removing it?
Eelco
Re: remove trace in Task?
Posted by rajeev_yadav <ra...@dell.com>.
I have added slf4j-log4j 1.5.2 version and I am stillinig getting this error.
Any suggestions which version is required to resolve this error.
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/remove-trace-in-Task-tp1904292p3349556.html
Sent from the Forum for Wicket Core developers mailing list archive at Nabble.com.
Re: remove trace in Task?
Posted by Gerolf Seitz <ge...@gmail.com>.
>
> at runtime you use a wrong version of slf4j if you get that error
the quickstart archetype still uses version 1.0.1 for slf4j-log4j whereas
1.4.2 should be used.
gerolf
On 9/17/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > On 9/17/07, Johan Compagner <jc...@gmail.com> wrote:
> > > somebody changed it from debug to trace so why is that done?
> >
> > Yeah, and that can give annoying error messages depending on your
> config:
> >
> > Exception in thread "ModificationWatcher Task"
> > java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
> > at org.apache.wicket.util.thread.Task$1.run(Task.java:103)
> >
> > But even if it is debug, I don't really see the point of that logging
> > code there. If you're debugging, just put something temporary in there
> > or set a breakpoint. Right?
> >
> > Eelco
> >
>
Re: remove trace in Task?
Posted by Johan Compagner <jc...@gmail.com>.
at runtime you use a wrong version of slf4j if you get that error
On 9/17/07, Eelco Hillenius <ee...@gmail.com> wrote:
> On 9/17/07, Johan Compagner <jc...@gmail.com> wrote:
> > somebody changed it from debug to trace so why is that done?
>
> Yeah, and that can give annoying error messages depending on your config:
>
> Exception in thread "ModificationWatcher Task"
> java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
> at org.apache.wicket.util.thread.Task$1.run(Task.java:103)
>
> But even if it is debug, I don't really see the point of that logging
> code there. If you're debugging, just put something temporary in there
> or set a breakpoint. Right?
>
> Eelco
>
Re: remove trace in Task?
Posted by Eelco Hillenius <ee...@gmail.com>.
On 9/17/07, Johan Compagner <jc...@gmail.com> wrote:
> somebody changed it from debug to trace so why is that done?
Yeah, and that can give annoying error messages depending on your config:
Exception in thread "ModificationWatcher Task"
java.lang.NoSuchMethodError: org.slf4j.Logger.isTraceEnabled()Z
at org.apache.wicket.util.thread.Task$1.run(Task.java:103)
But even if it is debug, I don't really see the point of that logging
code there. If you're debugging, just put something temporary in there
or set a breakpoint. Right?
Eelco
Re: remove trace in Task?
Posted by Johan Compagner <jc...@gmail.com>.
somebody changed it from debug to trace so why is that done?
On 9/17/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> This code:
>
> if (log.isTraceEnabled())
> {
> log.trace("Run the job: " + code.toString());
> }
>
> in Task looks completely unnecessary to me. Left-over of some debugging?
>
> Is anyone against removing it?
>
> Eelco
>