[GitHub] camel pull request #2415: CAMEL-12554 - camel-geocoder - Use new API

[jborza <gi...@git.apache.org>]

GitHub user jborza opened a pull request:

    https://github.com/apache/camel/pull/2415

    CAMEL-12554 - camel-geocoder - Use new API

    Hi,
    
    as described in 
    https://issues.apache.org/jira/browse/CAMEL-12554
    
    Geocoding and reverse geo-ip is now using a single library: Google Maps API Web Services
    
    Not sure if we usually remove component options in Camel, but there have been a few changes as follow:
    
    - I had to remove the options httpClientConfigurer, httpConnectionManager as the http connections are no longer managed by this library.
    - I also removed proxyAuthDomain, proxyAuthHost and proxyAuthMethod=NTLM as the new library doesn't support that either.
    
    Also as the API requires an API key the tests attempt to retrieve it from CAMEL_GEOCODER_APIKEY. Again, not sure what is the best practice - probably the same thing we'd do in Azure/AWS integration which probably requires some kind of API key to be included as well.
    
    Other option may be using a mock Google Maps endpoint, which I'm a bit reluctant to write as it may change any time.
    
    Regards,
    Juraj

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jborza/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2415
    
----
commit 2da4d5aa1e8e3773c2e62f9e1106fee08572a3f0
Author: jborza <jb...@...>
Date:   2018-06-10T16:27:46Z

    CAMEL-12554 - camel-geocoder - Use new API
    using com.google.maps:google-maps-services instead of com.google.code.geocoder-java:geocoder-java

commit caf0d4e2c70d1e3506ad84d794d3bf8236dfdbab
Author: jborza <jb...@...>
Date:   2018-07-08T06:51:56Z

    Merge branch 'master' of https://github.com/apache/camel

commit 29f84e91bae79feb5146bcf7fc0a815fb2e07b3c
Author: jborza <jb...@...>
Date:   2018-07-08T06:58:15Z

    implemented proxy support for GeoCoderEndpoint, removed commons-httpclient

commit a98e84584a65c8e970113ce8437bace562bcd95f
Author: jborza <jb...@...>
Date:   2018-07-08T07:05:42Z

    introduced google-maps-services-version parameter for the Maps API library

----


---

[GitHub] camel pull request #2415: CAMEL-12554 - camel-geocoder - Use new API

[onderson <gi...@git.apache.org>]

Github user onderson closed the pull request at:

    https://github.com/apache/camel/pull/2415


---