You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xiaozhigang (via GitHub)" <gi...@apache.org> on 2024/03/17 11:01:10 UTC
[PR] into master from 3.2.0-release [dubbo-spi-extensions]
xiaozhigang opened a new pull request, #297:
URL: https://github.com/apache/dubbo-spi-extensions/pull/297
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [ ] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng merged PR #297:
URL: https://github.com/apache/dubbo-spi-extensions/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #297:
URL: https://github.com/apache/dubbo-spi-extensions/pull/297#issuecomment-2007068352
need fix wasm ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #297:
URL: https://github.com/apache/dubbo-spi-extensions/pull/297#issuecomment-2012925197
## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/297?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 0.27%. Comparing base [(`ceff747`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/ceff7478d34ef7596c213371179843945fdeb9d6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`39f03fa`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/297?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #297 +/- ##
============================================
- Coverage 26.69% 0.27% -26.42%
+ Complexity 1087 6 -1081
============================================
Files 297 298 +1
Lines 13593 13620 +27
Branches 1720 1721 +1
============================================
- Hits 3629 38 -3591
- Misses 9609 13579 +3970
+ Partials 355 3 -352
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/297?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on code in PR #297:
URL: https://github.com/apache/dubbo-spi-extensions/pull/297#discussion_r1536775856
##########
dubbo-configcenter-extensions/dubbo-configcenter-etcd/src/test/java/org/apache/dubbo/configcenter/support/etcd/EtcdDynamicConfigurationTest.java:
##########
@@ -43,20 +47,49 @@
* Unit test for etcd config center support
* Integrate with https://github.com/etcd-io/jetcd#launcher
*/
+
@Disabled
public class EtcdDynamicConfigurationTest {
private static EtcdDynamicConfiguration config;
- public EtcdCluster etcdCluster = EtcdClusterFactory.buildCluster(getClass().getSimpleName(), 3, false);
-
- //public EtcdCluster etcdCluster= new Etcd.Builder().withClusterName(getClass().getSimpleName()).withNodes(3).withSsl(false).build();
+ private static final Logger logger = LoggerFactory.getLogger(EtcdDynamicConfigurationTest.class);
+ //public EtcdCluster etcdCluster= new Etcd.Builder().withClusterName(getClass().getSimpleName()).withNodes(3).withSsl(false).build();
private static Client client;
+ public EtcdCluster etcdCluster;
+
+ //这里会涉及到docker拉取镜像很慢
Review Comment:
please use english
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org