You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 10:43:14 UTC
[GitHub] [airflow] RichBr87 opened a new issue #16432: Colour options for tags on DAGS
RichBr87 opened a new issue #16432:
URL: https://github.com/apache/airflow/issues/16432
**Description**
Following the useful feature of tags with https://airflow.apache.org/docs/apache-airflow/2.0.0/howto/add-dag-tags.html it would be great if there was an option here to choose different colours for the tags.
**Use case / motivation**
As per the description, it would be great to see options for colour choices when adding tags. This will be really useful for those with several DAGs that might have dependencies on an upstream DAG where the same colour can be added. This will help users see at a glance which category/type a DAG is under.
Whilst it's a small thing, I think it will be really beneficial to users and certainly make the UI more colourful.
**Are you willing to submit a PR?**
**Related Issues**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860592819
Not sure if it's small thing as you mention.
Tags are just test that is taken from the DAG definition. It's not attribute that created from the UI and has configuration like Pools where you can just add another option and take it into account.
Where do you imagine that the color will be defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RichBr87 commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
RichBr87 commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860610870
Apologies I meant small as in a small change to request, not that the work would be small. I'm not fully technical, so please excuse the following - The tags on Airflow 2.0 (not sure about 1.10.8 etc as we skipped these versions) are an aqua colour which I am taking to be defined in the coding of the UI. Would it be possible to pre-define other colours and then the user adds one of the chosen colours as a variable after `tags=['example']`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860644347
If we were going to do it I think managing the colour of the tags should be done outside of the Dag file as Elad suggests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860592819
Not sure if it's small thing as you mention.
Tags are just text that is taken from the DAG definition. It's not attribute that created from the UI and has configuration like Pools where you can just add another option and take it into account.
Where do you imagine that the color will be defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860642353
I assume you mean something like:
`with models.DAG( dag_id="A", ..., tags=[('critical', RED)) as dag:`
I don't think this can be a solution as in you might also have:
`with models.DAG( dag_id="B", ..., tags=[('critical', BLUE)) as dag:`
The author of B doesn't necessarily knows that A already use the tag.
I think that in order to implement this feature the tags will have to be an object maintained as Airflow resource (like pools) and then DAGs can use a pre-defined tag but as mentioned I don't think this is a small feature.
lets see what other think.
In any case for the moment this is a theoretical discussion - this issue will get more attention (in terms of proposal review) if someone will be willing to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860592819
Not sure if it's small thing as you mention.
Tags are just text that is taken from the DAG definition. It's not resource that created in the system and has configuration like Pools where you can just add another option and take it into account.
Where do you imagine that the color will be defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860585785
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-860644506
This could be done as a config entry in Airflow.
On one hand it is not ideal (because users would not be able to modify it) but on the other hand since the tags are anyhow manually assigned by DAG writers as "free choice", I think we can assume that colors should be applied to the "globally known and common" tags which makes configuration as the best place to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ckljohn commented on issue #16432: Colour options for tags on DAGS
Posted by GitBox <gi...@apache.org>.
ckljohn commented on issue #16432:
URL: https://github.com/apache/airflow/issues/16432#issuecomment-977480000
You can use emoji as workaround. For example, 🔴🟡🟢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org