You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/09 16:02:07 UTC

[kudu-CR] [docker] Use the buildkit when building images

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15390


Change subject: [docker] Use the buildkit when building images
......................................................................

[docker] Use the buildkit when building images

The docker buildkit is an opt in build engine that is faster and offers more advanced image building features.
https://docs.docker.com/develop/develop-images/build_enhancements/

This patch sets `DOCKER_BUILDKIT=1` in the `docker-build.sh` file
to enable the buildkit. Follow on patches will use some of the
new features as well.

Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
---
M docker/docker-build.sh
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/15390/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Gerrit-Change-Number: 15390
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docker] Use the buildkit when building images

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15390 )

Change subject: [docker] Use the buildkit when building images
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Gerrit-Change-Number: 15390
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Mar 2020 18:17:51 +0000
Gerrit-HasComments: No

[kudu-CR] [docker] Use the buildkit when building images

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [docker] Use the buildkit when building images
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Gerrit-Change-Number: 15390
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docker] Use the buildkit when building images

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15390 )

Change subject: [docker] Use the buildkit when building images
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Gerrit-Change-Number: 15390
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Mar 2020 19:03:27 +0000
Gerrit-HasComments: No

[kudu-CR] [docker] Use the buildkit when building images

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15390

to look at the new patch set (#2).

Change subject: [docker] Use the buildkit when building images
......................................................................

[docker] Use the buildkit when building images

The docker buildkit is an opt in build engine that is faster and offers
more advanced image building features.
https://docs.docker.com/develop/develop-images/build_enhancements/

This patch sets `DOCKER_BUILDKIT=1` in the `docker-build.sh` file
to enable the buildkit. Follow on patches will use some of the
new features as well.

Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
---
M docker/docker-build.sh
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/15390/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Gerrit-Change-Number: 15390
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docker] Use the buildkit when building images

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15390 )

Change subject: [docker] Use the buildkit when building images
......................................................................

[docker] Use the buildkit when building images

The docker buildkit is an opt in build engine that is faster and offers
more advanced image building features.
https://docs.docker.com/develop/develop-images/build_enhancements/

This patch sets `DOCKER_BUILDKIT=1` in the `docker-build.sh` file
to enable the buildkit. Follow on patches will use some of the
new features as well.

Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Reviewed-on: http://gerrit.cloudera.org:8080/15390
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docker/docker-build.sh
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Grant Henke: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1bff68d65d0d4039efccabf7e1288163aafee0c
Gerrit-Change-Number: 15390
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)