[jira] [Commented] (HAWQ-46) Change data type for Metadata Versioning versions from int64 to uint64

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAWQ-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987815#comment-14987815 ] 

ASF GitHub Bot commented on HAWQ-46:
------------------------------------

Github user armenatzoglou closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/32


> Change data type for Metadata Versioning versions from int64 to uint64
> ----------------------------------------------------------------------
>
>                 Key: HAWQ-46
>                 URL: https://issues.apache.org/jira/browse/HAWQ-46
>             Project: Apache HAWQ
>          Issue Type: Improvement
>          Components: Metadata Versioning
>            Reporter: George Caragea
>            Assignee: George Caragea
>
> Metadata versioning versions are uint64 currently. But at some point during version generation, we use an atomic operation that returns int64 and then cast it to unsigned:
> {code}
> uint64
> mdver_next_global_version()
> {
> 	return (uint64) gp_atomic_add_64(mdver_global_version_counter, 1);
> }
> {code}
> Change all places that handle versions to use unsigned 64 bit integer values. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)