You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/13 03:04:22 UTC

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel

BenJFan commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125610797

   > Why does the Converter interface exist? Each engine can directly convert the sink of seatunnel to it‘s inner class when translating, and the converter just makes the class file more.
   
   I think Converter can make the convert logic clearer, let the engine translation implementers know what components they need to convert, and a more general code structure. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org