You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/02 14:00:34 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4741: VM has wrong network statistics with multiple nics in shared networks
ravening opened a new pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741
### Description
If vm has multiple nics belonging to different shared networks then
wrong statistics will be collected since network id is not considred
as primary key. Make the change so that primary key contains network
id so that traffic belonging to that corresponding network is shown
If network id is not added to primary key then all the traffic of all
shared networks will show up in one nic.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919564359
<b>Trillian test result (tid-2036)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39952 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4741-t2036-kvm-centos7.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Error` | 0.47 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-901428871
<b>Trillian test result (tid-1690)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40347 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4741-t1690-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900954073
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890291328
<b>Trillian test result (tid-1436)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42416 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4741-t1436-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 14.33 | test_diagnostics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-888881970
> ping @ravening please address conflicts and any outstanding issues
@rhtyd fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890013144
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890012407
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-889682149
<b>Trillian test result (tid-1411)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64508 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4741-t1411-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 427.68 | test_internal_lb.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3611.87 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3607.88 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 93.56 | test_kubernetes_clusters.py
test_router_dns_guestipquery | `Failure` | 174.48 | test_router_dnsservice.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 569.50 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 549.76 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919220226
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez edited a comment on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890141808
> @RodrigoDLopez always, but preferably/even better a coded integration test.
I think that it's not easy to do a automated test for those methods.
I'll run some manual tests here, and post my results as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez edited a comment on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890141808
> @RodrigoDLopez always, but preferably/even better a coded integration test.
I think that it's not easy to do a automated test for those methods.
I'll run some manual tests here, and put my results as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900926388
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-918890519
> Ping @ravening can you fix conflicts?
@rhtyd @weizhouapache done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-918904314
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-896167020
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#discussion_r685236272
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,7 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+ALTER TABLE cloud_usage.usage_network DROP PRIMARY KEY, ADD PRIMARY KEY (`account_id`,`zone_id`,`host_id`,`network_id`,`event_time_millis`);
Review comment:
@shwstppr thanks for pointing it out. have changed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-910213838
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-910180515
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-896693925
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-896167900
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890141808
> @RodrigoDLopez always, but preferably/even better a coded integration test.
I think that it's not easy to do a automated test for those methods.
I'll run some manual tests here, and put my results as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#discussion_r678908181
##########
File path: usage/src/main/java/com/cloud/usage/parser/NetworkUsageParser.java
##########
@@ -80,7 +80,7 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {
long zoneId = usageNetwork.getZoneId();
String key = "" + zoneId;
if (usageNetwork.getHostId() != 0) {
- key += "-Host" + usageNetwork.getHostId();
+ key += "-Host" + usageNetwork.getHostId() + "-Network-" + usageNetwork.getNetworkId();
Review comment:
@DaanHoogland this was not needed for networkid 0. the issue was only for extra nics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-902498232
@shwstppr are you satisfied with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900925678
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919082162
<b>Trillian Build Failed (tid-2037)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-913508635
@ravening can you move the sql change to engine/schema/src/main/resources/META-INF/db/schema-41520to41600.sql ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-889074530
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#discussion_r588374510
##########
File path: usage/src/main/java/com/cloud/usage/parser/NetworkUsageParser.java
##########
@@ -80,7 +80,7 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {
long zoneId = usageNetwork.getZoneId();
String key = "" + zoneId;
if (usageNetwork.getHostId() != 0) {
- key += "-Host" + usageNetwork.getHostId();
+ key += "-Host" + usageNetwork.getHostId() + "-Network-" + usageNetwork.getNetworkId();
Review comment:
should networkid be checked for 0 as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919048193
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-896693205
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919045279
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900926388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-896198660
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#discussion_r680189738
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,7 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+ALTER TABLE cloud_usage.usage_network DROP PRIMARY KEY, ADD PRIMARY KEY (`account_id`,`zone_id`,`host_id`,`network_id`,`event_time_millis`);
Review comment:
good catch @shwstppr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-800176722
> @ravening you want this on master only ? not on older branches?
@DaanHoogland will rebase it to 4.15. will rsolve conflicts as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900956926
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919041462
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-918843645
Ping @ravening can you fix conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-880467877
ping @ravening please address conflicts and any outstanding issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-889029594
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900957625
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-910180728
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#discussion_r680160315
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,7 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+ALTER TABLE cloud_usage.usage_network DROP PRIMARY KEY, ADD PRIMARY KEY (`account_id`,`zone_id`,`host_id`,`network_id`,`event_time_millis`);
Review comment:
@ravening these DB changes need to moved to 4.16 upgrade path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-918903578
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-889074809
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-900925678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-919218655
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-791482990
@ravening you want this on master only ? not on older branches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-890125148
> CLGTM.
> Do we need manual tests?
@RodrigoDLopez always, but preferably/even better a coded integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org