[jira] [Commented] (CB-11730) plugman miss the last file/folder when installing plugin on windows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574791#comment-15574791 ] 

ASF GitHub Bot commented on CB-11730:
-------------------------------------

Github user ahirun0426 commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/484#discussion_r83387722
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -330,7 +330,7 @@ function copyPlugin(pinfo, plugins_dir, link) {
     
         shell.rm('-rf', dest);
     
    -    if(!link && dest.indexOf(path.resolve(plugin_dir)) === 0) {
    +    if(!link && dest.indexOf(path.resolve(plugin_dir)+'\\') === 0) {
    --- End diff --
    
    Thank you pointed out the problem!
    Yes, it should be invalid value for macs/unix.
    
    I should change it to node official separator expression.


> plugman miss the last file/folder when installing plugin on windows
> -------------------------------------------------------------------
>
>                 Key: CB-11730
>                 URL: https://issues.apache.org/jira/browse/CB-11730
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.3.1
>         Environment: Windows
> plugman --version
> 1.2.1
> cordova --version
> 6.3.1
>            Reporter: Yasuharu Seki
>            Priority: Minor
>              Labels: triaged
>
> Steps to reproduce:
> - Create simple plugin
> $ plugman create --name SimplePlugin --plugin_id org.simple.plugin --plugin_version 1.0.0
> - Create cordova project it includes the name of plugin
> $ cordova create SimplePlugin_TestBed
> - Install the plugin into the created project
> $ cordova plugin add ../SimplePlugin
> -> Check the plugins/org.simple.plugin folder
>   Find www/ folder is missing.
> The reason is filenames.indexOf(relativeRootFolder) returns -1 when the target folder name cannot find in the plugin folder.
> The original code works good when the project is on the child folder.
> [plugin]/[project of plugin_testbed]
> But does not the project as sibling.
> [plugin]
> [project of plugin_testbed]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org