You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "sigalite (via GitHub)" <gi...@apache.org> on 2023/04/09 13:35:41 UTC

[GitHub] [flink] sigalite opened a new pull request, #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

sigalite opened a new pull request, #22371:
URL: https://github.com/apache/flink/pull/22371

   
   ## What is the purpose of the change
   enable the job manager and task manager communicate in a Kubernetes cluster with Istio and mTLS enabled.
   
   ## Brief change log
   Add the “appProtocol” in the task manager and job manager configuration, verify they are not overridden by the default definition in the decorators 
   
   ## Verifying this change
   This change is already covered by existing tests
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): don't know
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: don't know
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser closed pull request #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion
URL: https://github.com/apache/flink/pull/22371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22371:
URL: https://github.com/apache/flink/pull/22371#issuecomment-1501130037

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "60aac8039125ce954c91b63f578ea35467e7a054",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "60aac8039125ce954c91b63f578ea35467e7a054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 60aac8039125ce954c91b63f578ea35467e7a054 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #22371: [FLINK-28171] [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22371:
URL: https://github.com/apache/flink/pull/22371#issuecomment-1502877823

   @sigalite New features are not added to already released versions, so this PR needs to be adjusted towards `master`. Sorry for not noticing earlier. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org