You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by km...@apache.org on 2009/04/06 00:57:12 UTC

svn commit: r762182 - in /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src: main/java/org/apache/cayenne/conf/ main/java/org/apache/cayenne/exp/parser/ main/java/org/apache/cayenne/map/ main/java/org/apache/cayenne/query/ main/java/org/apach...

Author: kmenard
Date: Sun Apr  5 22:57:12 2009
New Revision: 762182

URL: http://svn.apache.org/viewvc?rev=762182&view=rev
Log:
Misc. code cleanups.

Modified:
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/conf/ConfigSaver.java
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/parser/SimpleNode.java
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/map/ClientObjEntity.java
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/BaseQueryMetadata.java
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/DefaultQueryMetadata.java
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/util/ResourceLocator.java
    cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/access/DataContextRefreshQueryTest.java

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/conf/ConfigSaver.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/conf/ConfigSaver.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/conf/ConfigSaver.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/conf/ConfigSaver.java Sun Apr  5 22:57:12 2009
@@ -152,7 +152,7 @@
             }
 
             if (schemaUpdateStrategy != null
-                    && !(schemaUpdateStrategy == SkipSchemaUpdateStrategy.class.getName())) {
+                    && !(schemaUpdateStrategy.equals(SkipSchemaUpdateStrategy.class.getName()))) {
                 pw.println("");
                 pw.print("\t\t schema-update-strategy=\""
                         + schemaUpdateStrategy.trim()

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/parser/SimpleNode.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/parser/SimpleNode.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/parser/SimpleNode.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/parser/SimpleNode.java Sun Apr  5 22:57:12 2009
@@ -126,7 +126,7 @@
      */
     @Override
     public Map<String, String> getPathAliases() {
-        return Collections.<String, String> emptyMap();
+        return Collections.emptyMap();
     }
 
     protected abstract String getExpressionOperator(int index);

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/map/ClientObjEntity.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/map/ClientObjEntity.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/map/ClientObjEntity.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/map/ClientObjEntity.java Sun Apr  5 22:57:12 2009
@@ -35,7 +35,7 @@
 
     ClientObjEntity(String name) {
         super(name);
-        this.primaryKeys = Collections.<ObjAttribute> emptyList();
+        this.primaryKeys = Collections.emptyList();
     }
 
     @Override

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/BaseQueryMetadata.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/BaseQueryMetadata.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/BaseQueryMetadata.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/BaseQueryMetadata.java Sun Apr  5 22:57:12 2009
@@ -264,7 +264,7 @@
      * @since 3.0
      */
     public Map<String, String> getPathSplitAliases() {
-        return Collections.<String, String> emptyMap();
+        return Collections.emptyMap();
     }
 
     /**

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/DefaultQueryMetadata.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/DefaultQueryMetadata.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/DefaultQueryMetadata.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/DefaultQueryMetadata.java Sun Apr  5 22:57:12 2009
@@ -149,6 +149,6 @@
     }
 
     public Map<String, String> getPathSplitAliases() {
-        return Collections.<String, String> emptyMap();
+        return Collections.emptyMap();
     }
 }

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/util/ResourceLocator.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/util/ResourceLocator.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/util/ResourceLocator.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/util/ResourceLocator.java Sun Apr  5 22:57:12 2009
@@ -281,7 +281,7 @@
      */
     public Collection<URL> getResources(String name) {
         URL resource = getResource(name);
-        return resource != null ? Collections.<URL> singleton(resource) : Collections
+        return resource != null ? Collections.singleton(resource) : Collections
                 .<URL> emptySet();
     }
 

Modified: cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/access/DataContextRefreshQueryTest.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/access/DataContextRefreshQueryTest.java?rev=762182&r1=762181&r2=762182&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/access/DataContextRefreshQueryTest.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/access/DataContextRefreshQueryTest.java Sun Apr  5 22:57:12 2009
@@ -332,9 +332,7 @@
         assertEquals("c", p1.getToArtist().getArtistName());
         assertEquals("c", p2.getToArtist().getArtistName());
 
-        RefreshQuery refresh = new RefreshQuery(new String[] {
-            "X"
-        });
+        RefreshQuery refresh = new RefreshQuery("X");
 
         // this should invalidate results for the next query run
         context.performQuery(refresh);