You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/12 04:52:53 UTC
[GitHub] [superset] Hokwang opened a new pull request #14586: add imagePullSecrets and fix imagePullPolicy
Hokwang opened a new pull request #14586:
URL: https://github.com/apache/superset/pull/14586
fix #14179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] danielewood commented on a change in pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
danielewood commented on a change in pull request #14586:
URL: https://github.com/apache/superset/pull/14586#discussion_r632659875
##########
File path: helm/superset/values.yaml
##########
@@ -104,7 +104,10 @@ extraConfigMountPath: "/app/configs"
image:
repository: apache/superset
tag: latest
Review comment:
Given that you are setting the chart app version to 1.1.0, this should be set to the tag of 1.1.0
apache/superset:latest is master
See: https://hub.docker.com/r/apache/superset/tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-845169579
@suddjian can you take care of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #14586: fix(helm): add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-848565810
done by #14686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on a change in pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
Hokwang commented on a change in pull request #14586:
URL: https://github.com/apache/superset/pull/14586#discussion_r632949465
##########
File path: helm/superset/values.yaml
##########
@@ -104,7 +104,10 @@ extraConfigMountPath: "/app/configs"
image:
repository: apache/superset
tag: latest
Review comment:
thanks, edited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang closed pull request #14586: fix(helm): add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
Hokwang closed pull request #14586:
URL: https://github.com/apache/superset/pull/14586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-841278463
@suddjian I edited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] danielewood commented on pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
danielewood commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-844646090
> @danielewood can you review once again?
Unfortunately I'm just a contributor, not a project maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-845351896
I am not a helm expert so I don't feel confident addressing this. @craig-rueda, how's this look to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-840108102
Hi, @Hokwang, thank you for the contribution.
Could you please provide some more information on what these changes are for, so that we can evaluate and get it merged? Preferably following the PR message template. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #14586: add imagePullSecrets and fix imagePullPolicy
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #14586:
URL: https://github.com/apache/superset/pull/14586#issuecomment-844641736
@danielewood can you review once again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org