You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/05 21:39:46 UTC

[GitHub] NathanQuinn commented on issue #4727: [webpack] setup lazy loading for all visualizations

NathanQuinn commented on issue #4727: [webpack] setup lazy loading for all visualizations
URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-386836907
 
 
   @williaster not sure if you are already familiar with this, but https://github.com/webpack-contrib/webpack-bundle-analyzer useful for deeper insights into the items impacting your bundle size here.  Beyond the deck.gl stuff, seems like brace, mathjs, and moment (locale) are most impactful.  There may be some opportunity to further optimize those, but would be interested in the webpack 4 upgrade stats before diving in on anything there.  Happy to help on this effort once you decide on direction to take this with @mistercrunch.
   
   This is the output I got from your branch with the above plugin:
   
   ![superset_bundle_impact](https://user-images.githubusercontent.com/17075065/39667677-2621846e-5081-11e8-888b-78ee04001225.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org