You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/26 16:39:55 UTC
[PR] Fix PostgreSQL reserved keyword projection aliases [shardingsphere]
terrymanu opened a new pull request, #39975:
URL: https://github.com/apache/shardingsphere/pull/39975
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostgreSQL reserved keyword projection aliases [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39975:
URL: https://github.com/apache/shardingsphere/pull/39975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostgreSQL reserved keyword projection aliases [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39975:
URL: https://github.com/apache/shardingsphere/pull/39975#issuecomment-5847979702
### Result
**Review Result: Mergeable**
The PostgreSQL parser now accepts `SELECT 1 AS desc` and preserves `desc` as the AST alias. This is a local code review only; CI was not reviewed.
### Evidence
- Explicit `AS` aliases now use `colLabel`; the Visitor handles both the new and existing alias paths.
- `select_keyword` moved from a negative case to a positive case that asserts the AST alias.
- PostgreSQL Parser IT: all 1,180 positive and 3 negative cases passed.
- Spotless passed; Checkstyle reported no violations.
### Coverage
- Standalone local change based on `8695937f09a`; all five changed files were reviewed.
- Grammar, Visitor, test assertions, and impact were checked. openGauss has an independent grammar and was not changed.
- No blockers found. The full repository build and CI were not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org