You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 07:38:48 UTC

[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #126: Add helm packaging to create_source_release.sh script

gyfora commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837151021



##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
   --exclude ".travis.yml" \
   . flink-kubernetes-operator-${RELEASE_VERSION}
 
+# Package sources
 tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
 gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^  repository: .*#  repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^  tag: .*#  tag: ${commit_hash}#" helm/flink-operator/values.yaml

Review comment:
       exactly, we publish the image build with the short commit hash




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org