You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/26 15:40:20 UTC
[GitHub] [airflow] kiwy42 opened a new issue #17854: Update OpenJDK in install_java.sh to proper up to date release
kiwy42 opened a new issue #17854:
URL: https://github.com/apache/airflow/issues/17854
**Description**
Java version inside script `install_java.sh` is an old release of OpenJDK 8. It for example does not support strong cryptographic cipher.
I have no idea if for license or laws or any legal issue it's possible but using something up to date would be awesome.
I personnaly uses this release: [OpenJdk-8u302b08.tar.gz](https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u302-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u302b08.tar.gz) .
Those OpenJDK release are done by [large consortium of company using Java everyday](https://adoptium.net/) and should be considered usable in any project.
**Use case / motivation**
At the moment this old jdk limit the security achievable by a java application. For example strong cipher with Kerberos token (all the big data ecosystem working with Kerberos could be impacted).
Maybe it's time to update, also this source as an industry standard (founded by IBM, amazon and so on..) should be updated in the long run and allow to easily upgrade and maintain latest OpenJDK 8 or 11 release.
**Are you willing to submit a PR?**
Yes sure I'm just not sure about licensing and stuff. If I have a legal and technical go I will consider doing the PR (I only see legal issue here nothing technical should be a problem).
I could also add a small argument to the script so it chooses between Java 8 or 11 (the 2 LTS release atm).
Changes should look like this:
```
DOWNLOAD_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u302-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u302b08.tar.gz'
[...]
curl -L -# --fail "${DOWNLOAD_URL}" --output "${TMP_DIR}/openjdk.tar.gz"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-906787440
Feel free to add a PR. This script is ONLY used for local development purpose with Breeze, so it has no impact on Airflow Production - but if you would like to upgrade it - feel free.kiwy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-906996872
For production environment, we have a separate guide: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/docker-stack/recipes.html
It uses less tricks and do some extra security checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-906996872
For production environment, we have a separate guide: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/docker-stack/recipes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-906996872
For production environment, we have a separate guide: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/docker-stack/recipes.html
It uses less tricks and do some extra verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-906787440
Feel free to add a PR. This script is ONLY used for local development purpose with Breeze, so it has no impact on Airflow Production - but if you would like to upgrade it - feel free!
Assigned you the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-907363767
@kiwy42: feel free to submit a PR to improve the documentation - adding Java Recipe, or improving Hadoop.
The right page is https://airflow.apache.org/docs/docker-stack/recipes.html - > and you can even see the "Suggest change on this page" there and contribute PR without leaving GitHub UI - same as commenting on issue here :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kiwy42 closed issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
kiwy42 closed issue #17854:
URL: https://github.com/apache/airflow/issues/17854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kiwy42 commented on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
kiwy42 commented on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-906970608
Well the script is also pretty descent when you want to install java in production image. Might as well have it up to date ;-)
I'll do it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kiwy42 commented on issue #17854: Update OpenJDK in install_java.sh to proper up to date release
Posted by GitBox <gi...@apache.org>.
kiwy42 commented on issue #17854:
URL: https://github.com/apache/airflow/issues/17854#issuecomment-907003845
>
>
> For production environment, we have a separate guide: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/docker-stack/recipes.html
> It uses less tricks and do some extra security checks.
hum, how interesting, I never found out about that one.
I guess my issue is useless then, howerver the recipes for hadoop should use the new site https://adoptium.net/ that will replace adoptJDK.
I'll close this one and will lookout for the other way to build production airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org