You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2025/08/12 23:53:36 UTC
[PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
allisonwang-db opened a new pull request, #51998:
URL: https://github.com/apache/spark/pull/51998
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR supports arrow UDTF in Spark Connect.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To support spark connect.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New UTs.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db closed pull request #51998: [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect
URL: https://github.com/apache/spark/pull/51998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
Posted by "ForVic (via GitHub)" <gi...@apache.org>.
ForVic commented on PR #51998:
URL: https://github.com/apache/spark/pull/51998#issuecomment-3198607920
nit: typo in PR title `PYHTON` -> `PYTHON`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #51998:
URL: https://github.com/apache/spark/pull/51998#issuecomment-3198604400
Thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #51998:
URL: https://github.com/apache/spark/pull/51998#discussion_r2277449369
##########
python/pyspark/sql/tests/connect/arrow/test_parity_arrow_udtf.py:
##########
@@ -0,0 +1,121 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from typing import Iterator
+from pyspark.sql.tests.arrow.test_arrow_udtf import ArrowUDTFTestsMixin
+from pyspark.testing.connectutils import ReusedConnectTestCase
+from pyspark.errors.exceptions.connect import PythonException
+from pyspark.sql.functions import arrow_udtf
+from pyspark.testing.sqlutils import have_pyarrow
+
+if have_pyarrow:
+ import pyarrow as pa
+
+
+class ArrowUDTFParityTests(ArrowUDTFTestsMixin, ReusedConnectTestCase):
Review Comment:
This module needs to be listed in `dev/sparktestsupport/modules.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #51998:
URL: https://github.com/apache/spark/pull/51998#discussion_r2277570437
##########
python/pyspark/sql/connect/udtf.py:
##########
@@ -106,6 +102,42 @@ def _create_py_udtf(
return _create_udtf(cls, returnType, name, eval_type, deterministic)
+def _create_pyarrow_udtf(
+ cls: Type,
+ returnType: Optional[Union[StructType, str]],
+ name: Optional[str] = None,
+ deterministic: bool = False,
+) -> "UserDefinedTableFunction":
+ """Create a PyArrow-native Python UDTF."""
+ # Validate PyArrow dependencies
+ require_minimum_pyarrow_version()
+
+ # Validate the handler class with PyArrow-specific checks
+ _validate_arrow_udtf_handler(cls, returnType)
+
+ return _create_udtf(
+ cls=cls,
+ returnType=returnType,
+ name=name,
+ evalType=PythonEvalType.SQL_ARROW_UDTF,
+ deterministic=deterministic,
+ )
+
+
+def _validate_arrow_udtf_handler(cls: Any, returnType: Optional[Union[StructType, str]]) -> None:
+ """Validate the handler class of a PyArrow UDTF."""
+ # First run standard UDTF validation
+ _validate_udtf_handler(cls, returnType)
+
+ # Block analyze method usage in arrow UDTFs
Review Comment:
I'm wondering why it's blocked for Arrow UDTF?
Or will we work on it later? If so, shall we have a ticket and TODO comment here to track it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53012][PYHTON] Support Arrow Python UDTF in Spark Connect [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #51998:
URL: https://github.com/apache/spark/pull/51998#discussion_r2278077211
##########
python/pyspark/sql/tests/connect/arrow/test_parity_arrow_udtf.py:
##########
@@ -0,0 +1,121 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from typing import Iterator
+from pyspark.sql.tests.arrow.test_arrow_udtf import ArrowUDTFTestsMixin
+from pyspark.testing.connectutils import ReusedConnectTestCase
+from pyspark.errors.exceptions.connect import PythonException
+from pyspark.sql.functions import arrow_udtf
+from pyspark.testing.sqlutils import have_pyarrow
+
+if have_pyarrow:
+ import pyarrow as pa
+
+
+class ArrowUDTFParityTests(ArrowUDTFTestsMixin, ReusedConnectTestCase):
+ # Override the error tests to use connect.PythonException instead of captured.PythonException
+ def test_arrow_udtf_error_not_iterator(self):
Review Comment:
If we change
```
from pyspark.errors.exceptions.captured import PythonException
```
to
```
from pyspark.errors import PythonException
```
in pyspark.sql.tests.arrow.test_arrow_udtf
then we don't need such changes in the parity tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org