[GitHub] [hive] veghlaci05 commented on pull request #3915: HIVE-26908 - Disable Initiator on HMS instance at the same time enabl…

[GitBox <gi...@apache.org>]

veghlaci05 commented on PR #3915:
URL: https://github.com/apache/hive/pull/3915#issuecomment-1378663402

   @tarak271 The change looks OK, my only concern here that with the introduction of the new config value, cleaner will stop working on existing clusters after the upgrade which can lead to ready for cleaning queue accumulation and performance issues, and finally escalations. For backward compatibility I would suggest to set an empty/null default value for the new config, and if it's not explicitly set, enable/disable cleaner according to the value in metastore.compactor.initiator.on. This also should be reflected in the description. @tarak271 , @deniskuzZ what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org