You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@sungard.com> on 2013/02/05 23:12:21 UTC
Re: [MERGE][ACS41] javelin to master
On Mon, Jan 28, 2013 at 6:26 PM, Alex Huang <Al...@citrix.com> wrote:
> John,
>
> While 1/31 is code-freeze, it doesn't mean dev stops writing unit tests to test out their code or new code to fix problems when qa find bugs. Without javelin in, it will mean they need to write once in today's home-grown component framework and unit testing and again in Springs when merge to master. I think given it's low risk, I don't see any reason why people want to duplicate that work. Why not just have it in 4.1 to begin with?
>
> --Alex
Alex,
How about unit tests for the Javelin code itself? Were any created?
Are there any that can be created?
While the merge is already complete, this seems like a great time for
the new structure to have unit tests built into it.
-chip
Re: [MERGE][ACS41] javelin to master
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Feb 06, 2013 at 08:37:44AM -0800, Alex Huang wrote:
>
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Wednesday, February 06, 2013 8:00 AM
> > To: Alex Huang
> > Cc: cloudstack-dev@incubator.apache.org; Edison Su
> > Subject: Re: [MERGE][ACS41] javelin to master
> >
> > On Tue, Feb 05, 2013 at 02:23:27PM -0800, Alex Huang wrote:
> > > > Alex,
> > > >
> > > > How about unit tests for the Javelin code itself? Were any created?
> > > > Are there any that can be created?
> > > >
> > > > While the merge is already complete, this seems like a great time for
> > > > the new structure to have unit tests built into it.
> > > >
> > >
> > > There were no unit tests for the Spring DI and AOP given that Spring is an
> > established entity.
> > >
> >
> > So there were no new classes introduced? If so, I guess that makes
> > sense. But if there were, then I'd disagree with not adding tests. I'm
> > not trying to be argumentative, just trying to understand.
>
> There were new classes introduce as utilities for unit testing. There's also a ComponentContext which are simple wrappers around aop. I can't think of anything else there.
>
> --Alex
>
>
Thanks for answering Alex!
-chip
RE: [MERGE][ACS41] javelin to master
Posted by Alex Huang <Al...@citrix.com>.
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, February 06, 2013 8:00 AM
> To: Alex Huang
> Cc: cloudstack-dev@incubator.apache.org; Edison Su
> Subject: Re: [MERGE][ACS41] javelin to master
>
> On Tue, Feb 05, 2013 at 02:23:27PM -0800, Alex Huang wrote:
> > > Alex,
> > >
> > > How about unit tests for the Javelin code itself? Were any created?
> > > Are there any that can be created?
> > >
> > > While the merge is already complete, this seems like a great time for
> > > the new structure to have unit tests built into it.
> > >
> >
> > There were no unit tests for the Spring DI and AOP given that Spring is an
> established entity.
> >
>
> So there were no new classes introduced? If so, I guess that makes
> sense. But if there were, then I'd disagree with not adding tests. I'm
> not trying to be argumentative, just trying to understand.
There were new classes introduce as utilities for unit testing. There's also a ComponentContext which are simple wrappers around aop. I can't think of anything else there.
--Alex
Re: [MERGE][ACS41] javelin to master
Posted by Chip Childers <ch...@sungard.com>.
On Tue, Feb 05, 2013 at 02:23:27PM -0800, Alex Huang wrote:
> > Alex,
> >
> > How about unit tests for the Javelin code itself? Were any created?
> > Are there any that can be created?
> >
> > While the merge is already complete, this seems like a great time for
> > the new structure to have unit tests built into it.
> >
>
> There were no unit tests for the Spring DI and AOP given that Spring is an established entity.
>
So there were no new classes introduced? If so, I guess that makes
sense. But if there were, then I'd disagree with not adding tests. I'm
not trying to be argumentative, just trying to understand.
> There were unit tests and integration tests written for the storage refactor portion using the Spring DI and AOP infrastructure. I'll let Edison speak to what those are.
>
That's great to hear!
> --Alex
>
RE: [MERGE][ACS41] javelin to master
Posted by Alex Huang <Al...@citrix.com>.
Edison,
You should enable the integration test suites. It shouldn't run in the normal mvn install but people should be able to run it with a different profile.
The goal of the integration has to be testing DataStoreProvider implementation without cloudstack at all. That's how you can know the DataStoreProvider implementation is completely decoupled from CloudStack. After doing this test, the DataStoreProvider implementer should have some assurance that CloudStack will run (even if it is in a deprecated form if there are bugs) with that implementation added to the plugins.
--Alex
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, February 06, 2013 11:12 AM
> To: Edison Su
> Cc: Alex Huang; cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE][ACS41] javelin to master
>
> On Wed, Feb 06, 2013 at 10:45:32AM -0800, Edison Su wrote:
> > There are unit test and integration test cases for storage components are
> using Spring and TestNG.
> > For example, there is a maven project called, *storage-integration-test*,
> which can conduct integration test with storage engine, storage plugins, and
> hypervisor resource. The integration test is written for devcloud
> environment, so it's been disabled in the maven build.
> > Regarding to unit test, , there are unit test cases under each storage
> component, for newly created classes, but not for all of them. Before I
> merge storage_refactor branch into master, I'll add more unit tests for these
> newly created classes.
> >
>
> Great news, thanks Edison!
Re: [MERGE][ACS41] javelin to master
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Feb 06, 2013 at 10:45:32AM -0800, Edison Su wrote:
> There are unit test and integration test cases for storage components are using Spring and TestNG.
> For example, there is a maven project called, *storage-integration-test*, which can conduct integration test with storage engine, storage plugins, and hypervisor resource. The integration test is written for devcloud environment, so it's been disabled in the maven build.
> Regarding to unit test, , there are unit test cases under each storage component, for newly created classes, but not for all of them. Before I merge storage_refactor branch into master, I'll add more unit tests for these newly created classes.
>
Great news, thanks Edison!
RE: [MERGE][ACS41] javelin to master
Posted by Edison Su <Ed...@citrix.com>.
> -----Original Message-----
> From: Alex Huang
> Sent: Tuesday, February 05, 2013 2:23 PM
> To: cloudstack-dev@incubator.apache.org
> Cc: Edison Su
> Subject: RE: [MERGE][ACS41] javelin to master
>
> > Alex,
> >
> > How about unit tests for the Javelin code itself? Were any created?
> > Are there any that can be created?
> >
> > While the merge is already complete, this seems like a great time for
> > the new structure to have unit tests built into it.
> >
>
> There were no unit tests for the Spring DI and AOP given that Spring is an
> established entity.
>
> There were unit tests and integration tests written for the storage refactor
> portion using the Spring DI and AOP infrastructure. I'll let Edison speak to
> what those are.
There are unit test and integration test cases for storage components are using Spring and TestNG.
For example, there is a maven project called, *storage-integration-test*, which can conduct integration test with storage engine, storage plugins, and hypervisor resource. The integration test is written for devcloud environment, so it's been disabled in the maven build.
Regarding to unit test, , there are unit test cases under each storage component, for newly created classes, but not for all of them. Before I merge storage_refactor branch into master, I'll add more unit tests for these newly created classes.
>
> --Alex
RE: [MERGE][ACS41] javelin to master
Posted by Alex Huang <Al...@citrix.com>.
> Alex,
>
> How about unit tests for the Javelin code itself? Were any created?
> Are there any that can be created?
>
> While the merge is already complete, this seems like a great time for
> the new structure to have unit tests built into it.
>
There were no unit tests for the Spring DI and AOP given that Spring is an established entity.
There were unit tests and integration tests written for the storage refactor portion using the Spring DI and AOP infrastructure. I'll let Edison speak to what those are.
--Alex