You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/26 19:24:34 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9019: ARROW-11040: [Rust] Simplified builders
jorgecarleitao opened a new pull request #9019:
URL: https://github.com/apache/arrow/pull/9019
This is a draft PR that simplifies the builders code. It has no semantic, execution or API change. It currently depends on pending PRs and therefore is a draft.
The main idea here is to generalize `[Large]ListBuilder`, `[Large]StringBuilder`, `[Large]BinaryBuilder` as `GenericListBuilder`, `GenericStringBuilder` and `GenericBinaryBuilder` respectively, thereby removing duplicated code.
The relevant changes in this PR are on `src/array/builders.rs` only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (e8a6702) into [master](https://codecov.io/gh/apache/arrow/commit/2f6874158e3d94bd5eb31765c2550dce8d015c19?el=desc) (2f68741) will **increase** coverage by `0.04%`.
> The diff coverage is `93.93%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.87% 82.92% +0.04%
==========================================
Files 201 201
Lines 49737 49631 -106
==========================================
- Hits 41219 41155 -64
+ Misses 8518 8476 -42
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.83% <91.45%> (+1.72%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.67% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.28% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [e1b38cd...bff3500](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751389644
https://issues.apache.org/jira/browse/ARROW-11040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-752956643
The full set of Rust CI tests did not run on this PR :(
Can you please rebase this PR against [apache/master](https://github.com/apache/arrow) to pick up the changes in https://github.com/apache/arrow/pull/9056 so that they do?
I apologize for the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (1c0599a) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.05%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.61% 82.66% +0.05%
==========================================
Files 202 202
Lines 50048 49948 -100
==========================================
- Hits 41347 41290 -57
+ Misses 8701 8658 -43
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.89% <93.10%> (+1.89%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.54% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.16% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.49% <100.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [51672b2...1c0599a](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (e8a6702) into [master](https://codecov.io/gh/apache/arrow/commit/dd5fe7095bb662236e27d3343eb82bc4375f93ef?el=desc) (dd5fe70) will **increase** coverage by `0.30%`.
> The diff coverage is `93.93%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.61% 82.92% +0.30%
==========================================
Files 202 201 -1
Lines 50052 49631 -421
==========================================
- Hits 41350 41155 -195
+ Misses 8702 8476 -226
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.83% <91.45%> (+1.83%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.67% <100.00%> (+0.06%)` | :arrow_up: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.28% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| ... and [54 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [51672b2...1c0599a](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#discussion_r549600518
##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -779,140 +781,31 @@ where
let offset_buffer = self.offsets_builder.finish();
let null_bit_buffer = self.bitmap_builder.finish();
let nulls = null_bit_buffer.count_set_bits();
Review comment:
I just noticed that we had named this unintuitively, as we're counting the set bits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (452bf5c) into [master](https://codecov.io/gh/apache/arrow/commit/a4f7c4a2acda874b3d6eb2eb4c986e7c3267c755?el=desc) (a4f7c4a) will **increase** coverage by `0.04%`.
> The diff coverage is `93.71%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.87% 82.92% +0.04%
==========================================
Files 201 201
Lines 49739 49632 -107
==========================================
- Hits 41220 41156 -64
+ Misses 8519 8476 -43
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.83% <91.45%> (+1.72%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.69% <100.00%> (-0.05%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.28% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.49% <100.00%> (ø)` | |
| [rust/arrow/src/tensor.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdGVuc29yLnJz) | `87.50% <100.00%> (ø)` | |
| [rust/parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9hcnJheV9yZWFkZXIucnM=) | `75.49% <100.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [a4f7c4a...452bf5c](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (e8a6702) into [master](https://codecov.io/gh/apache/arrow/commit/2f6874158e3d94bd5eb31765c2550dce8d015c19?el=desc) (2f68741) will **increase** coverage by `0.04%`.
> The diff coverage is `93.93%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.87% 82.92% +0.04%
==========================================
Files 201 201
Lines 49737 49631 -106
==========================================
- Hits 41219 41155 -64
+ Misses 8518 8476 -42
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.83% <91.45%> (+1.72%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.67% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.28% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [2440c9e...6077fe3](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#discussion_r549605250
##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -779,140 +781,31 @@ where
let offset_buffer = self.offsets_builder.finish();
let null_bit_buffer = self.bitmap_builder.finish();
let nulls = null_bit_buffer.count_set_bits();
Review comment:
Okay, thanks for the heads-up. I'll check my emails
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (e8a6702) into [master](https://codecov.io/gh/apache/arrow/commit/a4f7c4a2acda874b3d6eb2eb4c986e7c3267c755?el=desc) (a4f7c4a) will **increase** coverage by `0.04%`.
> The diff coverage is `93.93%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.87% 82.92% +0.04%
==========================================
Files 201 201
Lines 49739 49631 -108
==========================================
- Hits 41220 41155 -65
+ Misses 8519 8476 -43
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.83% <91.45%> (+1.72%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.67% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.28% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [a4f7c4a...e8a6702](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9019:
URL: https://github.com/apache/arrow/pull/9019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (12a5b20) into [master](https://codecov.io/gh/apache/arrow/commit/cd22be6efedbf9832b5ea875ca59bb42de7b6c28?el=desc) (cd22be6) will **increase** coverage by `0.05%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.55% 82.61% +0.05%
==========================================
Files 203 203
Lines 50043 49942 -101
==========================================
- Hits 41315 41259 -56
+ Misses 8728 8683 -45
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.10% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.89% <93.10%> (+1.89%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.54% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.16% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.47% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [cd22be6...12a5b20](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#discussion_r549601635
##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -779,140 +781,31 @@ where
let offset_buffer = self.offsets_builder.finish();
let null_bit_buffer = self.bitmap_builder.finish();
let nulls = null_bit_buffer.count_set_bits();
Review comment:
`unset`? it proves the point, though 🤣
FYI, @nevi-me , the tests are not running (INFRA team deactivated most actions), so we need to be careful with merging to master. There is a thread in the mailing list about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (0bcd4dd) into [master](https://codecov.io/gh/apache/arrow/commit/a4f7c4a2acda874b3d6eb2eb4c986e7c3267c755?el=desc) (a4f7c4a) will **increase** coverage by `0.04%`.
> The diff coverage is `93.90%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.87% 82.92% +0.04%
==========================================
Files 201 201
Lines 49739 49631 -108
==========================================
- Hits 41220 41155 -65
+ Misses 8519 8476 -43
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.83% <91.45%> (+1.72%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.67% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.27% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.28% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [a4f7c4a...0bcd4dd](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9019: ARROW-11040: [Rust] Simplified builders
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9019:
URL: https://github.com/apache/arrow/pull/9019#issuecomment-751392410
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=h1) Report
> Merging [#9019](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=desc) (f9d69eb) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.04%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 82.61% 82.66% +0.04%
==========================================
Files 202 202
Lines 50048 49948 -100
==========================================
- Hits 41347 41289 -58
+ Misses 8701 8659 -42
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.12% <ø> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.89% <93.10%> (+1.89%)` | :arrow_up: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.54% <100.00%> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.16% <100.00%> (-0.11%)` | :arrow_down: |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `83.87% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/utils.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3V0aWxzLnJz) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3N1YnN0cmluZy5ycw==) | `98.29% <100.00%> (ø)` | |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <100.00%> (ø)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.49% <100.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/arrow/pull/9019/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=footer). Last update [51672b2...f9d69eb](https://codecov.io/gh/apache/arrow/pull/9019?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org