You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/07/27 04:38:51 UTC

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3071: Proper JDK & location of the binary classes in mx projects

JaroslavTulach commented on a change in pull request #3071:
URL: https://github.com/apache/netbeans/pull/3071#discussion_r677111771



##########
File path: java/java.mx.project/src/org/netbeans/modules/java/mx/project/Compliance.java
##########
@@ -99,12 +99,23 @@ public String toString() {
         }
     }
 
+    boolean matches(Compliance check) {
+        if (min > check.min) {

Review comment:
       `return false` if outside of range, but you are right, there should be a test: 1ce26972e9f0




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists