[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

[yhuai <gi...@git.apache.org>]

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10061#discussion_r63808009
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -96,6 +100,7 @@ private[spark] object JsonProtocol {
             executorMetricsUpdateToJson(metricsUpdate)
           case blockUpdated: SparkListenerBlockUpdated =>
             throw new MatchError(blockUpdated)  // TODO(ekl) implement this
    +      case _ => parse(mapper.writeValueAsString(event))
    --- End diff --
    
    It is very possible that we silently pull in unnecessary information. If we have new event types, we should handle those explicitly instead of relying on this line. I am proposing to revert this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org