You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/25 08:02:47 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #5602: [AIRFLOW-4983] Feature/dataflow operator python3

potiuk commented on a change in pull request #5602: [AIRFLOW-4983] Feature/dataflow operator python3
URL: https://github.com/apache/airflow/pull/5602#discussion_r307163284
 
 

 ##########
 File path: tests/contrib/hooks/test_gcp_dataflow_hook.py
 ##########
 @@ -111,6 +138,55 @@ def test_start_python_dataflow(self, mock_conn,
         self.assertListEqual(sorted(mock_dataflow.call_args[0][0]),
                              sorted(expected_cmd))
 
+    @mock.patch(DATAFLOW_STRING.format('uuid.uuid4'))
 
 Review comment:
   This is a lot of code duplication. We should change it to "@parameterized" tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services