You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/19 03:07:31 UTC
[GitHub] [echarts] plainheart opened a new pull request #14704: fix(map): ensure children have been added to group before calling `resetEventTriggerForRegion`.
plainheart opened a new pull request #14704:
URL: https://github.com/apache/echarts/pull/14704
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Fix #14699.
### Fixed issues
- #14699
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
The tooltip can't show for missing `seriesIndex` in the inner store of the element of zrender.
The seriesIndex will be set by `viewBuildCtx.data.setItemGraphicEl(dataIdx, eventTrigger)` in `resetEventTriggerForRegion`.
But `regionGroup` has no children yet when calling `resetEventTriggerForRegion` for the inappropriate invoking order, which causes the `el.traverse(setItemDataAndSeriesIndex, el);` won't be invoked.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
Adjust the invoking order.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
Please refer to `test/map-default.html`
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14704: fix(map): ensure children have been added to group before calling `resetEventTriggerForRegion`.
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14704:
URL: https://github.com/apache/echarts/pull/14704#issuecomment-825353714
@fazulk It will be included in 5.1.1. Which will be released in the early next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14704: fix(map): ensure children have been added to group before calling `resetEventTriggerForRegion`.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14704:
URL: https://github.com/apache/echarts/pull/14704#issuecomment-822944995
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14704: fix(map): ensure children have been added to group before calling `resetEventTriggerForRegion`.
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14704:
URL: https://github.com/apache/echarts/pull/14704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fazulk commented on pull request #14704: fix(map): ensure children have been added to group before calling `resetEventTriggerForRegion`.
Posted by GitBox <gi...@apache.org>.
fazulk commented on pull request #14704:
URL: https://github.com/apache/echarts/pull/14704#issuecomment-824198485
When will this be made available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org