You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by sz...@apache.org on 2009/05/15 03:21:25 UTC

svn commit: r774980 - in /hadoop/core/trunk: ./ src/core/org/apache/hadoop/fs/ src/core/org/apache/hadoop/fs/kfs/ src/core/org/apache/hadoop/fs/s3/ src/core/org/apache/hadoop/util/

Author: szetszwo
Date: Fri May 15 01:21:25 2009
New Revision: 774980

URL: http://svn.apache.org/viewvc?rev=774980&view=rev
Log:
HADOOP-5842.  Fix a few javac warnings under packages fs and util.  Contributed by Hairong Kuang

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/ChecksumException.java
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/FSError.java
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/FileSystem.java
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3Exception.java
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3FileSystemException.java
    hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/VersionMismatchException.java
    hadoop/core/trunk/src/core/org/apache/hadoop/util/ProcfsBasedProcessTree.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Fri May 15 01:21:25 2009
@@ -591,6 +591,9 @@
     HADOOP-5822.  Fix javac warnings in several dfs tests related to unncessary
     casts.  (Jakob Homan via szetszwo)
 
+    HADOOP-5842.  Fix a few javac warnings under packages fs and util.
+    (Hairong Kuang via szetszwo)
+
 Release 0.20.1 - Unreleased
 
   INCOMPATIBLE CHANGES

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/ChecksumException.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/ChecksumException.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/ChecksumException.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/ChecksumException.java Fri May 15 01:21:25 2009
@@ -22,6 +22,7 @@
 
 /** Thrown for checksum errors. */
 public class ChecksumException extends IOException {
+  private static final long serialVersionUID = 1L;
   private long pos;
   public ChecksumException(String description, long pos) {
     super(description);

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/FSError.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/FSError.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/FSError.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/FSError.java Fri May 15 01:21:25 2009
@@ -21,6 +21,8 @@
 /** Thrown for unexpected filesystem errors, presumed to reflect disk errors
  * in the native filesystem. */
 public class FSError extends Error {
+  private static final long serialVersionUID = 1L;
+
   FSError(Throwable cause) {
     super(cause);
   }

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/FileSystem.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/FileSystem.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/FileSystem.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/FileSystem.java Fri May 15 01:21:25 2009
@@ -1600,6 +1600,7 @@
    * @return a Map having a key as URI scheme and value as Statistics object
    * @deprecated use {@link #getAllStatistics} instead
    */
+  @Deprecated
   public static synchronized Map<String, Statistics> getStatistics() {
     Map<String, Statistics> result = new HashMap<String, Statistics>();
     for(Statistics stat: statisticsTable.values()) {

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java Fri May 15 01:21:25 2009
@@ -85,7 +85,7 @@
           if (statistics != null) {
             statistics.incrementBytesRead(1);
           }
-          return ((int) (b[0] & 0xff));
+          return b[0] & 0xff;
         }
         return -1;
     }

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3Exception.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3Exception.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3Exception.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3Exception.java Fri May 15 01:21:25 2009
@@ -25,6 +25,8 @@
  */
 public class S3Exception extends IOException {
 
+  private static final long serialVersionUID = 1L;
+
   public S3Exception(Throwable t) {
     super(t);
   }

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3FileSystemException.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3FileSystemException.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3FileSystemException.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/S3FileSystemException.java Fri May 15 01:21:25 2009
@@ -23,6 +23,8 @@
  * Thrown when there is a fatal exception while using {@link S3FileSystem}.
  */
 public class S3FileSystemException extends IOException {
+  private static final long serialVersionUID = 1L;
+
   public S3FileSystemException(String message) {
     super(message);
   }

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/VersionMismatchException.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/VersionMismatchException.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/VersionMismatchException.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/fs/s3/VersionMismatchException.java Fri May 15 01:21:25 2009
@@ -22,6 +22,8 @@
  * in {@link S3FileSystem}.
  */
 public class VersionMismatchException extends S3FileSystemException {
+  private static final long serialVersionUID = 1L;
+
   public VersionMismatchException(String clientVersion, String dataVersion) {
     super("Version mismatch: client expects version " + clientVersion +
         ", but data has version " +

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/util/ProcfsBasedProcessTree.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/util/ProcfsBasedProcessTree.java?rev=774980&r1=774979&r2=774980&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/util/ProcfsBasedProcessTree.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/util/ProcfsBasedProcessTree.java Fri May 15 01:21:25 2009
@@ -281,7 +281,7 @@
   private static Integer getValidPID(String pid) {
     Integer retPid = -1;
     try {
-      retPid = Integer.parseInt((String) pid);
+      retPid = Integer.parseInt(pid);
       if (retPid <= 0) {
         retPid = -1;
       }