You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/21 02:29:22 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #6519: [LINT] Use fmt off to disable problematic black fmt
tqchen opened a new pull request #6519:
URL: https://github.com/apache/incubator-tvm/pull/6519
cc @jroesch @ZihengJiang @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6519: [LINT] Use fmt off to disable problematic black fmt
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6519:
URL: https://github.com/apache/incubator-tvm/pull/6519#discussion_r491879208
##########
File path: python/tvm/topi/testing/pool3d_python.py
##########
@@ -20,12 +20,20 @@
import numpy as np
import tvm
-def pool3d_ncdhw_python(np_data, kernel,
- strides, padding,
- out_shape, pool_type,
- count_include_pad=True,
- ceil_mode=False, dtype="float32"):
+
+def pool3d_ncdhw_python(
+ np_data,
+ kernel,
+ strides,
+ padding,
+ out_shape,
+ pool_type,
+ count_include_pad=True,
+ ceil_mode=False,
+ dtype="float32",
+):
"""baseline for max_pool3d and avg_pool3d, default layout is "NCDHW"""
+ # fmt: off
Review comment:
This looks good, we should probably send an issue to black devs, just haven't gotten around to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6519: [LINT] Use fmt off to disable problematic black fmt
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6519:
URL: https://github.com/apache/incubator-tvm/pull/6519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6519: [LINT] Use fmt off to disable problematic black fmt
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6519:
URL: https://github.com/apache/incubator-tvm/pull/6519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6519: [LINT] Use fmt off to disable problematic black fmt
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6519:
URL: https://github.com/apache/incubator-tvm/pull/6519#discussion_r491879208
##########
File path: python/tvm/topi/testing/pool3d_python.py
##########
@@ -20,12 +20,20 @@
import numpy as np
import tvm
-def pool3d_ncdhw_python(np_data, kernel,
- strides, padding,
- out_shape, pool_type,
- count_include_pad=True,
- ceil_mode=False, dtype="float32"):
+
+def pool3d_ncdhw_python(
+ np_data,
+ kernel,
+ strides,
+ padding,
+ out_shape,
+ pool_type,
+ count_include_pad=True,
+ ceil_mode=False,
+ dtype="float32",
+):
"""baseline for max_pool3d and avg_pool3d, default layout is "NCDHW"""
+ # fmt: off
Review comment:
This looks good, we should probably send an issue to black devs, just haven't gotten around to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org