You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2015/11/19 23:16:39 UTC
Review Request 40502: Move displayType element for HAWQ/PXF from
site_properties.json to stack definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40502/
-----------------------------------------------------------
Review request for Ambari, jun aoki and Oleksandr Diachenko.
Bugs: AMBARI-13929
https://issues.apache.org/jira/browse/AMBARI-13929
Repository: ambari
Description
-------
Move displayType element for HAWQ/PXF from site_properties.json to stack definition.
Example:
{
"name": "hawq_master_address_host",
"displayType": "componentHost",
"filename": "hawq-site.xml",
"category": "General",
"serviceName": "HAWQ",
"index": 0
},
<configuration>
<property>
<name>hawq_master_address_host</name>
<display-name>HAWQ Master</display-name>
<value>localhost</value>
<description>The host name of HAWQ master.</description>
<value-attributes>
<type>componentHost</type>
</value-attributes>
</property>
Move the displayType to value-attributes tag in hawq-site.xml
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 41b10dc
ambari-web/app/data/HDP2.3/site_properties.js bdb0ef2
ambari-web/test/data/HDP2.3/site_properties_test.js 5179283
Diff: https://reviews.apache.org/r/40502/diff/
Testing
-------
mvn test
Thanks,
bhuvnesh chaudhary
Re: Review Request 40502: Move displayType element for HAWQ/PXF from
site_properties.json to stack definition
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40502/#review107274
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksandr Diachenko
On Nov. 19, 2015, 10:16 p.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40502/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 10:16 p.m.)
>
>
> Review request for Ambari, jun aoki and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-13929
> https://issues.apache.org/jira/browse/AMBARI-13929
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Move displayType element for HAWQ/PXF from site_properties.json to stack definition.
> Example:
> {
> "name": "hawq_master_address_host",
> "displayType": "componentHost",
> "filename": "hawq-site.xml",
> "category": "General",
> "serviceName": "HAWQ",
> "index": 0
> },
> <configuration>
> <property>
> <name>hawq_master_address_host</name>
> <display-name>HAWQ Master</display-name>
> <value>localhost</value>
> <description>The host name of HAWQ master.</description>
> <value-attributes>
> <type>componentHost</type>
> </value-attributes>
> </property>
> Move the displayType to value-attributes tag in hawq-site.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 41b10dc
> ambari-web/app/data/HDP2.3/site_properties.js bdb0ef2
> ambari-web/test/data/HDP2.3/site_properties_test.js 5179283
>
> Diff: https://reviews.apache.org/r/40502/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Fwd: Review Request 40502: Move displayType element for HAWQ/PXF from
site_properties.json to stack definition
Posted by Bhuvnesh Chaudhary <bc...@pivotal.io>.
All,
The patch submitted via https://issues.apache.org/jira/browse/AMBARI-13929 for
trunk also needs to be merged to branch 2.1. Could you as well please
review the same as well.
https://reviews.apache.org/r/40502/
Thanks,
Bhuvnesh Chaudhary
Email: bchau <bc...@gopivotal.com>dhary@pivotal.io
Desk: +1-650-846-1696 | Mobile: +1-973-906-6976
---------- Forwarded message ----------
From: bhuvnesh chaudhary <bc...@pivotal.io>
Date: Fri, Nov 20, 2015 at 11:39 AM
Subject: Re: Review Request 40502: Move displayType element for HAWQ/PXF
from site_properties.json to stack definition
To: bhuvnesh chaudhary <bc...@pivotal.io>, Alejandro Fernandez <
afernandez@hortonworks.com>, Jayush Luniya <jl...@hortonworks.com>
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40502/
Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya,
and Oleksandr Diachenko.
By bhuvnesh chaudhary.
*Updated Nov. 20, 2015, 7:39 p.m.*
*Bugs: * AMBARI-13929 <https://issues.apache.org/jira/browse/AMBARI-13929>
*Repository: * ambari
Description
Move displayType element for HAWQ/PXF from site_properties.json to
stack definition.
Example:
{
"name": "hawq_master_address_host",
"displayType": "componentHost",
"filename": "hawq-site.xml",
"category": "General",
"serviceName": "HAWQ",
"index": 0
},
<configuration>
<property>
<name>hawq_master_address_host</name>
<display-name>HAWQ Master</display-name>
<value>localhost</value>
<description>The host name of HAWQ master.</description>
<value-attributes>
<type>componentHost</type>
</value-attributes>
</property>
Move the displayType to value-attributes tag in hawq-site.xml
Testing
mvn test
Diffs
- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
(41b10dc)
- ambari-web/app/data/HDP2.3/site_properties.js (bdb0ef2)
- ambari-web/test/data/HDP2.3/site_properties_test.js (5179283)
View Diff <https://reviews.apache.org/r/40502/diff/>