You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 03:45:16 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #38595: [SPARK-41090][SQL] Throw Exception for `db_name.view_name` when creating temp view by Dataset API

amaliujia commented on code in PR #38595:
URL: https://github.com/apache/spark/pull/38595#discussion_r1021050959


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -933,6 +933,11 @@
     ],
     "sqlState" : "42000"
   },
+  "TEMP_VIEW_DOES_NOT_BELONG_TO_A_DATABASE" : {

Review Comment:
    I believe still need ` case _: ParseException => throw QueryCompilationErrors.invalidViewNameError(viewName)`
   
   Per my understanding that will happen if someone uses `$#Qviewname` as view name which is not allowed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org