You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/17 04:25:01 UTC

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #18493: 3D Upsampling

ChaiBapchya commented on issue #18493:
URL: https://github.com/apache/incubator-mxnet/issues/18493#issuecomment-645140735


   Great to have this use-case. @andevellicus Thanks for bringing it up. While your experience in Julie will be handy, we would still need work to be done on MXNet Backend [C/C++] because those few lines that @leezu  mentioned would go somewhere here
   
   For Upsampling Forward & Backward
   https://github.com/apache/incubator-mxnet/blob/3b23c2de950fb0e4d44560f4c7ea933a520c526c/src/operator/nn/upsampling-inl.h#L100
   
   CPU-specific implementation
   For e.g. Shape currently checks for 4D input [2D image]
   https://github.com/apache/incubator-mxnet/blob/eceb5f2c1c494094c1a697286f2c4560b7ca472e/src/operator/nn/upsampling.cc#L44-L45
   https://github.com/apache/incubator-mxnet/blob/eceb5f2c1c494094c1a697286f2c4560b7ca472e/src/operator/nn/upsampling.cc#L61-L62
   
   There don't seem to be GPU-specific implementations at the moment. So we are good on that.
   
   You can take a stab at updating the forward & backward implementations. Additionally, we could add a test for this 3D image use-case 
   Similar to
   https://github.com/apache/incubator-mxnet/blob/f1f3f44166e2e47afad6c65025fb48dd47efeb65/tests/python/gpu/test_operator_gpu.py#L1481-L1489
   
   I can help review your PR. Feel free to ping me if you need any help / have specific doubts related to contributing code to the MXNet Backend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org