You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Night-Amber3301 (via GitHub)" <gi...@apache.org> on 2023/10/06 05:09:08 UTC

[PR] Updated sort.rs [arrow-datafusion]

Night-Amber3301 opened a new pull request, #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751

   solves: #7750
   
   Replaced `SortExec: fetch={fetch}, expr=[{}]` with `SortExec: TopK(fetch={fetch}), expr=[{}]` in [sort.rs](https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-plan/src/sorts/sort.rs) file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "Night-Amber3301 (via GitHub)" <gi...@apache.org>.
Night-Amber3301 commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751613313

   I've merged it up from main, please check it out.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "Night-Amber3301 (via GitHub)" <gi...@apache.org>.
Night-Amber3301 commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751689580

   @liukun4515 Here are the logs:
   
   @Night-Amber3301 ➜ /workspaces/arrow-datafusion (patch-1) $ git log
   commit 29e2dc3387805a0caa29741e333795597c686675 (HEAD -> patch-1, origin/patch-1)
   Author: Pratibhanu Jarngal <99...@users.noreply.github.com>
   Date:   Fri Oct 6 10:38:20 2023 +0530
   
       Updated sort.rs
       
       solves: #7750
       
       Replaced `SortExec: fetch={fetch}, expr=[{}]` with 'SortExec: TopK(fetch={fetch}), expr=[{}]' in [sort.rs](https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-plan/src/sorts/sort.rs) file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "Night-Amber3301 (via GitHub)" <gi...@apache.org>.
Night-Amber3301 commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751427174

   Yeah sure, thanks for consideration, I would love to work on it, will go through it in a while.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on code in PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#discussion_r1349536708


##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -769,7 +769,7 @@ impl DisplayAs for SortExec {
                         write!(
                             f,
                             // TODO should this say topk?
-                            "SortExec: fetch={fetch}, expr=[{}]",
+                            "SortExec: TopK(fetch={fetch}), expr=[{}]",

Review Comment:
   If the sort does not use TopK, should we keep the format like `"SortExec: fetch={fetch}, expr=[{}]"` 🤔?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "liukun4515 (via GitHub)" <gi...@apache.org>.
liukun4515 commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751686338

   > Any suggestions on why is this happening?
   
   Can you provide your git log to here?
   
   you can get the git log by 
   ```
   git log
   ```
   
   in your project workspace


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on code in PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#discussion_r1349536708


##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -769,7 +769,7 @@ impl DisplayAs for SortExec {
                         write!(
                             f,
                             // TODO should this say topk?
-                            "SortExec: fetch={fetch}, expr=[{}]",
+                            "SortExec: TopK(fetch={fetch}), expr=[{}]",

Review Comment:
   If the sort does not use TopK, should we format it like `"SortExec: fetch={fetch}, expr=[{}]"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#discussion_r1349746527


##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -769,7 +769,7 @@ impl DisplayAs for SortExec {
                         write!(
                             f,
                             // TODO should this say topk?
-                            "SortExec: fetch={fetch}, expr=[{}]",
+                            "SortExec: TopK(fetch={fetch}), expr=[{}]",

Review Comment:
   Yes, I think that is the intention



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751675267

   > I've merged it up from main, please check it out.
   
   It looks like somehow your changes were not pushed to github (the UI doesn't show any new changes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751679040

   > Any suggestions on why is this happening?
   
   Perhaps you haven't pushed the change to github? What command are you using?
   
   I would expect you would hav to do something like
   ```
   git push
   ```
   
   And make sure your "upstream" was set to your fork
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "Night-Amber3301 (via GitHub)" <gi...@apache.org>.
Night-Amber3301 commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751677438

   Any suggestions on why is this happening?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1751404949

   This looks really close @Night-Amber3301 -- thank you. I think some of the clippy errors will be resolved if you merge up from main. And it looks like there are just a few more tests to update
   
   Let me know if you would like to some help and thanks agian!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#issuecomment-1755778826

   Marking as draft as this PR is not waiting on feedback


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated sort.rs to show `TopK` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #7751: Updated sort.rs to show `TopK`
URL: https://github.com/apache/arrow-datafusion/pull/7751


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org