You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/27 06:20:47 UTC
[GitHub] [spark] yaooqinn opened a new pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
yaooqinn opened a new pull request #31671:
URL: https://github.com/apache/spark/pull/31671
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787036997
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135533/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787096417
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40124/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788961003
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135652/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787480598
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40143/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787810975
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40169/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787958292
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135588/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787036790
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40114/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787946407
**[Test build #135588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135588/testReport)** for PR 31671 at commit [`e949845`](https://github.com/apache/spark/commit/e949845c5aa29f03dbe85adcac530aa08a7bc7da).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788560677
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40200/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r585208568
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
##########
@@ -408,10 +409,11 @@ object SetWarehouseLocationTest extends Logging {
}
- if (sparkSession.conf.get(WAREHOUSE_PATH.key) != expectedWarehouseLocation) {
+ val qualifiedWH = FileUtils.makeQualified(
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787099383
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40124/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788795028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787597150
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40152/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584475089
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -253,9 +253,8 @@ object SharedState extends Logging {
val warehousePath = if (hiveWarehouseDir != null && sparkWarehouseOption.isEmpty) {
// If hive.metastore.warehouse.dir is set and spark.sql.warehouse.dir is not set,
// we will respect the value of hive.metastore.warehouse.dir.
- sparkConf.set(WAREHOUSE_PATH.key, hiveWarehouseDir)
logInfo(s"${WAREHOUSE_PATH.key} is not set, but $hiveWarehouseKey is set. Setting" +
- s" ${WAREHOUSE_PATH.key} to the value of $hiveWarehouseKey ('$hiveWarehouseDir').")
Review comment:
why do we remove ` ('$hiveWarehouseDir')`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788961003
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135652/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788953133
**[Test build #135652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135652/testReport)** for PR 31671 at commit [`c4b4cda`](https://github.com/apache/spark/commit/c4b4cdae144aa7c9cb1da58d9773b4d5096baa45).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r585211922
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSharedStateSuite.scala
##########
@@ -56,9 +58,11 @@ class HiveSharedStateSuite extends SparkFunSuite {
initialConfigs.foreach { case (k, v) => builder.config(k, v) }
val ss = builder.getOrCreate()
val state = ss.sharedState
- assert(sc.conf.get(WAREHOUSE_PATH.key) === wareHouseDir,
+ val qualifiedWH =
Review comment:
done, thanks for the suggestion @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788760578
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787800622
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40169/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787036896
**[Test build #135533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135533/testReport)** for PR 31671 at commit [`bd26d8f`](https://github.com/apache/spark/commit/bd26d8f98a7ba9027446f6e2118ff15f656879ec).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787475677
**[Test build #135562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135562/testReport)** for PR 31671 at commit [`897a55c`](https://github.com/apache/spark/commit/897a55c64b6d0b02432397c83ce9764349033265).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788558137
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40200/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787034185
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40114/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787124308
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135543/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787099383
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40124/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787806627
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40169/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584475849
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
##########
@@ -424,7 +426,7 @@ object SetWarehouseLocationTest extends Logging {
val tableMetadata =
catalog.getTableMetadata(TableIdentifier("testLocation", Some("default")))
val expectedLocation =
- CatalogUtils.stringToURI(s"file:${expectedWarehouseLocation.toString}/testlocation")
+ CatalogUtils.stringToURI(s"$qualifiedWH/testlocation")
Review comment:
does `qualifiedWH` start with `file:`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788795028
**[Test build #135652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135652/testReport)** for PR 31671 at commit [`c4b4cda`](https://github.com/apache/spark/commit/c4b4cdae144aa7c9cb1da58d9773b4d5096baa45).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584475526
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -412,4 +415,32 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach {
}
assert(!logAppender.loggingEvents.exists(_.getRenderedMessage.contains(msg)))
}
+
+ test("SPARK-34558: warehouse path should be qualified and populate to spark and hadoop conf") {
+ Seq(".", "..", "dir0", "dir0/dir1", "/dir0/dir1", "./dir0").foreach { pathStr =>
+ val path = new Path(pathStr)
+ val conf = new SparkConf().set(WAREHOUSE_PATH, pathStr)
+ val session = SparkSession.builder()
+ .master("local")
+ .config(conf)
+ .getOrCreate()
+ val hadoopConf = session.sessionState.newHadoopConf()
+ val expected = path.getFileSystem(hadoopConf).makeQualified(path).toString
+ // session related configs
+ assert(hadoopConf.get("hive.metastore.warehouse.dir") === expected)
+ assert(session.conf.get(WAREHOUSE_PATH) === expected)
+ assert(session.sessionState.conf.warehousePath === expected)
+
+ // shared configs
+ assert(session.sharedState.conf.get(WAREHOUSE_PATH) === expected)
+ assert(session.sharedState.hadoopConf.get("hive.metastore.warehouse.dir") === expected)
+
+ // spark context configs
+ assert(session.sparkContext.conf.get(WAREHOUSE_PATH) === expected)
+ assert(session.sparkContext.hadoopConfiguration.get("hive.metastore.warehouse.dir") ===
+ expected)
+
+ reset()
Review comment:
it will be done in `afterEach`, do we need it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788981350
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584465609
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -253,9 +253,8 @@ object SharedState extends Logging {
val warehousePath = if (hiveWarehouseDir != null && sparkWarehouseOption.isEmpty) {
// If hive.metastore.warehouse.dir is set and spark.sql.warehouse.dir is not set,
// we will respect the value of hive.metastore.warehouse.dir.
- sparkConf.set(WAREHOUSE_PATH.key, hiveWarehouseDir)
logInfo(s"${WAREHOUSE_PATH.key} is not set, but $hiveWarehouseKey is set. Setting" +
Review comment:
These log messages look not very useful to me personally before or after this change. But we do not vary the logging logic with this change, I am not sure if there is anyone who relies on these outputs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787958292
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135588/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788560677
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40200/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31671:
URL: https://github.com/apache/spark/pull/31671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787124308
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135543/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787648744
What's concrete steps to reproduce this error by users?
```
Caused by: java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: file:./lakehouse
at org.apache.hadoop.fs.Path.initialize(Path.java:263)
at org.apache.hadoop.fs.Path.<init>(Path.java:254)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787576745
cc @cloud-fan @maropu @HyukjinKwon thanks for reviewing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788560658
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40200/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584483797
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
##########
@@ -424,7 +426,7 @@ object SetWarehouseLocationTest extends Logging {
val tableMetadata =
catalog.getTableMetadata(TableIdentifier("testLocation", Some("default")))
val expectedLocation =
- CatalogUtils.stringToURI(s"file:${expectedWarehouseLocation.toString}/testlocation")
+ CatalogUtils.stringToURI(s"$qualifiedWH/testlocation")
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788550208
**[Test build #135621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135621/testReport)** for PR 31671 at commit [`c4b4cda`](https://github.com/apache/spark/commit/c4b4cdae144aa7c9cb1da58d9773b4d5096baa45).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787810975
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40169/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788550208
**[Test build #135621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135621/testReport)** for PR 31671 at commit [`c4b4cda`](https://github.com/apache/spark/commit/c4b4cdae144aa7c9cb1da58d9773b4d5096baa45).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788814356
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40232/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787670358
> What's concrete steps to reproduce this error by users?
>
> ```
> Caused by: java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: file:./lakehouse
> at org.apache.hadoop.fs.Path.initialize(Path.java:263)
> at org.apache.hadoop.fs.Path.<init>(Path.java:254)
> ```
with a fresh built or downloaded spark dist package, which means there is no default DB yet, then run a simple case like,
```scala
bin/spark-submit --master local -c spark.sql.warehouse.dir=lakehouse --class org.apache.yao.spark.sql.ShowHiveTables ~/sugar/target/sugar-1.0-SNAPSHOT.jar
```
and the source code can be found https://github.com/yaooqinn/sugar/blob/master/src/main/scala/org/apache/yao/spark/sql/ShowHiveTables.scala, which is a quite simple one w/ `show databases`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584486820
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -412,4 +415,32 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach {
}
assert(!logAppender.loggingEvents.exists(_.getRenderedMessage.contains(msg)))
}
+
+ test("SPARK-34558: warehouse path should be qualified and populate to spark and hadoop conf") {
+ Seq(".", "..", "dir0", "dir0/dir1", "/dir0/dir1", "./dir0").foreach { pathStr =>
Review comment:
shall we create multiple tests?
```
Seq(".", "..", "dir0", "dir0/dir1", "/dir0/dir1", "./dir0").foreach { pathStr =>
test(s"SPARK-34558: warehouse path ($pathStr) should be qualified and populate to spark and hadoop conf") ...
}
```
then we don't need to touch `afterEach`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r585208494
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSharedStateSuite.scala
##########
@@ -56,9 +58,11 @@ class HiveSharedStateSuite extends SparkFunSuite {
initialConfigs.foreach { case (k, v) => builder.config(k, v) }
val ss = builder.getOrCreate()
val state = ss.sharedState
- assert(sc.conf.get(WAREHOUSE_PATH.key) === wareHouseDir,
+ val qualifiedWH =
Review comment:
nit: `qualifiedWHPath`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787522889
**[Test build #135562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135562/testReport)** for PR 31671 at commit [`897a55c`](https://github.com/apache/spark/commit/897a55c64b6d0b02432397c83ce9764349033265).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787036790
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40114/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787585779
**[Test build #135571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135571/testReport)** for PR 31671 at commit [`d1f32ce`](https://github.com/apache/spark/commit/d1f32ce31c151999c61ec39a4bf6e1475b86cb43).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787478562
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40143/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584488254
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -412,4 +415,32 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach {
}
assert(!logAppender.loggingEvents.exists(_.getRenderedMessage.contains(msg)))
}
+
+ test("SPARK-34558: warehouse path should be qualified and populate to spark and hadoop conf") {
+ Seq(".", "..", "dir0", "dir0/dir1", "/dir0/dir1", "./dir0").foreach { pathStr =>
Review comment:
OK~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787015457
**[Test build #135533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135533/testReport)** for PR 31671 at commit [`bd26d8f`](https://github.com/apache/spark/commit/bd26d8f98a7ba9027446f6e2118ff15f656879ec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787036997
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135533/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584453940
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -253,9 +253,8 @@ object SharedState extends Logging {
val warehousePath = if (hiveWarehouseDir != null && sparkWarehouseOption.isEmpty) {
// If hive.metastore.warehouse.dir is set and spark.sql.warehouse.dir is not set,
// we will respect the value of hive.metastore.warehouse.dir.
- sparkConf.set(WAREHOUSE_PATH.key, hiveWarehouseDir)
logInfo(s"${WAREHOUSE_PATH.key} is not set, but $hiveWarehouseKey is set. Setting" +
Review comment:
We still need this `logInfo` even after the code in L256 is removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787091360
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40124/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787085339
**[Test build #135543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135543/testReport)** for PR 31671 at commit [`8650c11`](https://github.com/apache/spark/commit/8650c114e44c51600dd3338257851cd05adb554b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787527967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135562/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787527967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135562/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788814356
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40232/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788630819
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135621/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584485480
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -253,9 +253,8 @@ object SharedState extends Logging {
val warehousePath = if (hiveWarehouseDir != null && sparkWarehouseOption.isEmpty) {
// If hive.metastore.warehouse.dir is set and spark.sql.warehouse.dir is not set,
// we will respect the value of hive.metastore.warehouse.dir.
- sparkConf.set(WAREHOUSE_PATH.key, hiveWarehouseDir)
logInfo(s"${WAREHOUSE_PATH.key} is not set, but $hiveWarehouseKey is set. Setting" +
- s" ${WAREHOUSE_PATH.key} to the value of $hiveWarehouseKey ('$hiveWarehouseDir').")
Review comment:
it's not final yet and the final one will be print right after this at https://github.com/apache/spark/pull/31671/files#diff-45744d86661942d414a6e12f72e1d24f62b1db1ce1a5a21a60dfb52abf7611b0R274
```
Setting hive.metastore.warehouse.dir ('null') to the value of spark.sql.warehouse.dir ('datalake').
```
log like the above looks confusing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787785080
**[Test build #135588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135588/testReport)** for PR 31671 at commit [`e949845`](https://github.com/apache/spark/commit/e949845c5aa29f03dbe85adcac530aa08a7bc7da).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788637943
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135626/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788660561
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40206/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787785080
**[Test build #135588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135588/testReport)** for PR 31671 at commit [`e949845`](https://github.com/apache/spark/commit/e949845c5aa29f03dbe85adcac530aa08a7bc7da).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787479829
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40143/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787121946
**[Test build #135543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135543/testReport)** for PR 31671 at commit [`8650c11`](https://github.com/apache/spark/commit/8650c114e44c51600dd3338257851cd05adb554b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584484398
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -412,4 +415,32 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach {
}
assert(!logAppender.loggingEvents.exists(_.getRenderedMessage.contains(msg)))
}
+
+ test("SPARK-34558: warehouse path should be qualified and populate to spark and hadoop conf") {
+ Seq(".", "..", "dir0", "dir0/dir1", "/dir0/dir1", "./dir0").foreach { pathStr =>
+ val path = new Path(pathStr)
+ val conf = new SparkConf().set(WAREHOUSE_PATH, pathStr)
+ val session = SparkSession.builder()
+ .master("local")
+ .config(conf)
+ .getOrCreate()
+ val hadoopConf = session.sessionState.newHadoopConf()
+ val expected = path.getFileSystem(hadoopConf).makeQualified(path).toString
+ // session related configs
+ assert(hadoopConf.get("hive.metastore.warehouse.dir") === expected)
+ assert(session.conf.get(WAREHOUSE_PATH) === expected)
+ assert(session.sessionState.conf.warehousePath === expected)
+
+ // shared configs
+ assert(session.sharedState.conf.get(WAREHOUSE_PATH) === expected)
+ assert(session.sharedState.hadoopConf.get("hive.metastore.warehouse.dir") === expected)
+
+ // spark context configs
+ assert(session.sparkContext.conf.get(WAREHOUSE_PATH) === expected)
+ assert(session.sparkContext.hadoopConfiguration.get("hive.metastore.warehouse.dir") ===
+ expected)
+
+ reset()
Review comment:
we need to `reset()` here as it is in `foreach` and each round need to be `reset()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787030941
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40114/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787475677
**[Test build #135562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135562/testReport)** for PR 31671 at commit [`897a55c`](https://github.com/apache/spark/commit/897a55c64b6d0b02432397c83ce9764349033265).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788609778
**[Test build #135621 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135621/testReport)** for PR 31671 at commit [`c4b4cda`](https://github.com/apache/spark/commit/c4b4cdae144aa7c9cb1da58d9773b4d5096baa45).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584454025
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -264,12 +263,15 @@ object SharedState extends Logging {
// we will set hive.metastore.warehouse.dir to the default value of spark.sql.warehouse.dir.
val sparkWarehouseDir = sparkWarehouseOption.getOrElse(WAREHOUSE_PATH.defaultValueString)
logInfo(s"Setting $hiveWarehouseKey ('$hiveWarehouseDir') to the value of " +
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787614261
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40152/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787608434
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40152/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787631584
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135571/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584475139
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -264,12 +263,15 @@ object SharedState extends Logging {
// we will set hive.metastore.warehouse.dir to the default value of spark.sql.warehouse.dir.
val sparkWarehouseDir = sparkWarehouseOption.getOrElse(WAREHOUSE_PATH.defaultValueString)
logInfo(s"Setting $hiveWarehouseKey ('$hiveWarehouseDir') to the value of " +
- s"${WAREHOUSE_PATH.key} ('$sparkWarehouseDir').")
- sparkConf.set(WAREHOUSE_PATH.key, sparkWarehouseDir)
- hadoopConf.set(hiveWarehouseKey, sparkWarehouseDir)
+ s"${WAREHOUSE_PATH.key}.")
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787480598
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40143/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788633305
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31671:
URL: https://github.com/apache/spark/pull/31671#discussion_r584465609
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -253,9 +253,8 @@ object SharedState extends Logging {
val warehousePath = if (hiveWarehouseDir != null && sparkWarehouseOption.isEmpty) {
// If hive.metastore.warehouse.dir is set and spark.sql.warehouse.dir is not set,
// we will respect the value of hive.metastore.warehouse.dir.
- sparkConf.set(WAREHOUSE_PATH.key, hiveWarehouseDir)
logInfo(s"${WAREHOUSE_PATH.key} is not set, but $hiveWarehouseKey is set. Setting" +
Review comment:
These log messages themselves look not very useful to me personally before or after this change. But we do not vary the logging logic with this change, I am not sure if there is anyone who relies on these outputs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787614261
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40152/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787015457
**[Test build #135533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135533/testReport)** for PR 31671 at commit [`bd26d8f`](https://github.com/apache/spark/commit/bd26d8f98a7ba9027446f6e2118ff15f656879ec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788630819
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135621/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-788637943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787085339
**[Test build #135543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135543/testReport)** for PR 31671 at commit [`8650c11`](https://github.com/apache/spark/commit/8650c114e44c51600dd3338257851cd05adb554b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31671: [SPARK-34558][SQL] warehouse path should be qualified ahead of populating and use
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31671:
URL: https://github.com/apache/spark/pull/31671#issuecomment-787631584
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135571/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org