[GitHub] [cassandra] yifan-c commented on a change in pull request #824: CASSANDRA-16143: Streaming fails when s SSTable writer finish() exceeds internode_tcp_user_timeout

[GitBox <gi...@apache.org>]

yifan-c commented on a change in pull request #824:
URL: https://github.com/apache/cassandra/pull/824#discussion_r533777976



##########
File path: src/java/org/apache/cassandra/config/Config.java
##########
@@ -178,6 +178,8 @@
     // (it takes much longer than 30s) as of Linux 4.12. If you want something that high set this to 0
     // (which picks up the OS default) and configure the net.ipv4.tcp_retries2 sysctl to be ~8.
     public int internode_tcp_user_timeout_in_ms = 30000;
+    // Similar to internode_tcp_user_timeout_in_ms but used specifically for streaming connection.
+    public int internode_streaming_tcp_user_timeout_in_ms = 0;

Review comment:
       > What does it mean for this timeout to default to zero instead of 30000 like its counterpart above?
   
   Finding a proper default value is hard. The reason I set it 0 is that it seems to be working better for streaming, according to the ticket description. 
   I guess, we can set it the same as the previous value (30000) and adjust it on-demand. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org