You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Jens Grivolla (JIRA)" <ji...@apache.org> on 2008/12/03 16:09:44 UTC
[jira] Created: (MAHOUT-101) MySQLJDBCDiffStorage.java: hard coded
column names
MySQLJDBCDiffStorage.java: hard coded column names
--------------------------------------------------
Key: MAHOUT-101
URL: https://issues.apache.org/jira/browse/MAHOUT-101
Project: Mahout
Issue Type: Bug
Components: Collaborative Filtering
Reporter: Jens Grivolla
Priority: Minor
Some column names in MySQLJDBCDiffStorage.java are hard coded instead of using the values provided in the constructor.
proposed fix:
in MySQLJDBCDiffStorage.java:
116c117
< " WHERE " + itemIDBColumn + " = item_id AND " + userIDColumn + "=? UNION DISTINCT" +
---
> " WHERE " + itemIDBColumn + " = " + itemIDColumn + " AND " + userIDColumn + "=? UNION DISTINCT" +
118c119
< " WHERE " + itemIDAColumn + " = item_id AND " + userIDColumn +
---
> " WHERE " + itemIDAColumn + " = " + itemIDColumn + " AND " + userIDColumn +
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-101) MySQLJDBCDiffStorage.java: hard coded
column names
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-101.
------------------------------
Resolution: Fixed
Assignee: Sean Owen
Yep, great catch. Fixed.
> MySQLJDBCDiffStorage.java: hard coded column names
> --------------------------------------------------
>
> Key: MAHOUT-101
> URL: https://issues.apache.org/jira/browse/MAHOUT-101
> Project: Mahout
> Issue Type: Bug
> Components: Collaborative Filtering
> Reporter: Jens Grivolla
> Assignee: Sean Owen
> Priority: Minor
>
> Some column names in MySQLJDBCDiffStorage.java are hard coded instead of using the values provided in the constructor.
> proposed fix:
> in MySQLJDBCDiffStorage.java:
> 116c117
> < " WHERE " + itemIDBColumn + " = item_id AND " + userIDColumn + "=? UNION DISTINCT" +
> ---
> > " WHERE " + itemIDBColumn + " = " + itemIDColumn + " AND " + userIDColumn + "=? UNION DISTINCT" +
> 118c119
> < " WHERE " + itemIDAColumn + " = item_id AND " + userIDColumn +
> ---
> > " WHERE " + itemIDAColumn + " = " + itemIDColumn + " AND " + userIDColumn +
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.