You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Devin Leamy <dl...@x.com> on 2024/02/12 17:02:19 UTC
Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
Adds a test that checks that cgroups2 is enabled on the testing host.
Diffs
-----
src/Makefile.am d1e16d1c97d41107328bcd8cd6eefb5dacdf557d
src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/74871/diff/1/
Testing
-------
Thanks,
Devin Leamy
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/#review226242
-----------------------------------------------------------
Ship it!
Ship It!
- Devin Leamy
On Feb. 26, 2024, 8:52 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74871/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2024, 8:52 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
> Adds a test that checks that cgroups2 is enabled on the testing host.
>
>
> Diffs
> -----
>
> src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a
> src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
> src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74871/diff/4/
>
>
> Testing
> -------
>
> make -j128 check
>
>
> Thanks,
>
> Devin Leamy
>
>
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/
-----------------------------------------------------------
(Updated Feb. 26, 2024, 8:52 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
Adds a test that checks that cgroups2 is enabled on the testing host.
Diffs
-----
src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a
src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/74871/diff/4/
Testing (updated)
-------
make -j128 check
Thanks,
Devin Leamy
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/
-----------------------------------------------------------
(Updated Feb. 26, 2024, 8:52 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
Adds a test that checks that cgroups2 is enabled on the testing host.
Diffs (updated)
-----
src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a
src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/74871/diff/4/
Changes: https://reviews.apache.org/r/74871/diff/3-4/
Testing
-------
Thanks,
Devin Leamy
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/
-----------------------------------------------------------
(Updated Feb. 26, 2024, 8:22 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
Adds a test that checks that cgroups2 is enabled on the testing host.
Diffs (updated)
-----
src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a
src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/74871/diff/3/
Changes: https://reviews.apache.org/r/74871/diff/2-3/
Testing
-------
Thanks,
Devin Leamy
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/
-----------------------------------------------------------
(Updated Feb. 26, 2024, 8:17 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
Adds a test that checks that cgroups2 is enabled on the testing host.
Diffs (updated)
-----
src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a
src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/74871/diff/2/
Changes: https://reviews.apache.org/r/74871/diff/1-2/
Testing
-------
Thanks,
Devin Leamy
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
> On Feb. 20, 2024, 4:08 a.m., Benjamin Mahler wrote:
> > src/Makefile.am
> > Lines 2863 (patched)
> > <https://reviews.apache.org/r/74871/diff/1/?file=2285169#file2285169line2863>
> >
> > nit: nbd, but can you align the backspace here? (1 less tab character)
Updated.
> On Feb. 20, 2024, 4:08 a.m., Benjamin Mahler wrote:
> > src/tests/containerizer/cgroups2_tests.cpp
> > Lines 17-22 (patched)
> > <https://reviews.apache.org/r/74871/diff/1/?file=2285171#file2285171line17>
> >
> > doesn't look like these includes are needed yet? let's add them only when we need them (as a general rule)
Incidentally <stout/tests/utils.hpp> imports <process/gtest.hpp> and <stout/gtest.hpp> which are used, so we only need that one :+1:.
- Devin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/#review226222
-----------------------------------------------------------
On Feb. 12, 2024, 5:02 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74871/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2024, 5:02 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
> Adds a test that checks that cgroups2 is enabled on the testing host.
>
>
> Diffs
> -----
>
> src/Makefile.am d1e16d1c97d41107328bcd8cd6eefb5dacdf557d
> src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
> src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74871/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Devin Leamy
>
>
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Devin Leamy <dl...@x.com>.
> On Feb. 20, 2024, 4:08 a.m., Benjamin Mahler wrote:
> > src/tests/containerizer/cgroups2_tests.cpp
> > Lines 17-22 (patched)
> > <https://reviews.apache.org/r/74871/diff/1/?file=2285171#file2285171line17>
> >
> > doesn't look like these includes are needed yet? let's add them only when we need them (as a general rule)
>
> Devin Leamy wrote:
> Incidentally <stout/tests/utils.hpp> imports <process/gtest.hpp> and <stout/gtest.hpp> which are used, so we only need that one :+1:.
Correction: <stout/tests/utils.hpp> imports <stout/gtest.hpp> and <gtest/gtest.h>. <process/gtest.hpp> is unused.
- Devin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/#review226222
-----------------------------------------------------------
On Feb. 26, 2024, 8:52 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74871/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2024, 8:52 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
> Adds a test that checks that cgroups2 is enabled on the testing host.
>
>
> Diffs
> -----
>
> src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a
> src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
> src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74871/diff/4/
>
>
> Testing
> -------
>
> make -j128 check
>
>
> Thanks,
>
> Devin Leamy
>
>
Re: Review Request 74871: [cgroups2] Adds cgroups2_tests.cpp to the Mesos test suit.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74871/#review226222
-----------------------------------------------------------
src/Makefile.am
Lines 2863 (patched)
<https://reviews.apache.org/r/74871/#comment314468>
nit: nbd, but can you align the backspace here? (1 less tab character)
src/tests/containerizer/cgroups2_tests.cpp
Lines 17-22 (patched)
<https://reviews.apache.org/r/74871/#comment314467>
doesn't look like these includes are needed yet? let's add them only when we need them (as a general rule)
src/tests/containerizer/cgroups2_tests.cpp
Lines 32 (patched)
<https://reviews.apache.org/r/74871/#comment314464>
maybe your editor can automatically strip trailing whitespace?
- Benjamin Mahler
On Feb. 12, 2024, 5:02 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74871/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2024, 5:02 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces cgroups2_tests.cpp which will hold the cgroups2 tests.
> Adds a test that checks that cgroups2 is enabled on the testing host.
>
>
> Diffs
> -----
>
> src/Makefile.am d1e16d1c97d41107328bcd8cd6eefb5dacdf557d
> src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a
> src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74871/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Devin Leamy
>
>