You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/01/26 14:28:16 UTC
[GitHub] [hop] pjfanning opened a new pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
pjfanning opened a new pull request #1297:
URL: https://github.com/apache/hop/pull/1297
(jar name change for poi 5 - but tika uses poi 4)
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [X] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1297:
URL: https://github.com/apache/hop/pull/1297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pjfanning commented on pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #1297:
URL: https://github.com/apache/hop/pull/1297#issuecomment-1022253835
@hansva I don't much about how the assembly.xml files work - is it possible to include version numbers?
https://github.com/apache/hop/blob/master/assemblies/plugins/transforms/tika/src/assembly/assembly.xml#L80
For the tika plugin, we don't want latest poi jars - we need to cap the poi version at 4.1.2. See https://mvnrepository.com/artifact/org.apache.tika/tika-parser-microsoft-module/2.1.0 - uses poi 4.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1297:
URL: https://github.com/apache/hop/pull/1297#issuecomment-1022277759
Alright, I have an other error but it is totally not related to POI so I'll handle it.
Thank you so much for helping us bring this to a good end! I really love how the ASF community helps each other out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1297:
URL: https://github.com/apache/hop/pull/1297#issuecomment-1022261071
The assemblies are based on the pom that is above them so in this case it is linked to tika version 2.1
As far as I can see the libraries included are correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1297:
URL: https://github.com/apache/hop/pull/1297#issuecomment-1022267414
It's a bit a hassle to get our packaging right, but we split everything up exactly for this reason. some of our plugins need older versions of dependencies and we want them to co-exist putting everything together will cause all sorts of errors :)
I'm running the test locally now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] pjfanning commented on pull request #1297: HOP-3706: use correct name of poi-ooxml-schemas jar
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #1297:
URL: https://github.com/apache/hop/pull/1297#issuecomment-1022266364
@hansva can you merge this and see if it helps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org