[GitHub] [spark] techaddict commented on a diff in pull request #39451: [SPARK-41832][CONNECT][PYTHON] Fix `DataFrame.unionByName`, add allow_missing_columns

[GitBox <gi...@apache.org>]

techaddict commented on code in PR #39451:
URL: https://github.com/apache/spark/pull/39451#discussion_r1064101288


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1123,7 +1123,7 @@ class SparkConnectPlanner(session: SparkSession) {
         val combinedUnion = CombineUnions(
           Union(
             Seq(transformRelation(u.getLeftInput), transformRelation(u.getRightInput)),
-            byName = u.getByName))
+            byName = u.getByName, allowMissingCol = u.getAllowMissingColumns))

Review Comment:
   @amaliujia added a `InvalidPlanInput` exception and a negative test case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org