You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/04/26 09:52:03 UTC
[jira] [Commented] (WICKET-3636) BookmarkablePageLink ::
setParameter int versions missing
[ https://issues.apache.org/jira/browse/WICKET-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025120#comment-13025120 ]
Martin Grigorov commented on WICKET-3636:
-----------------------------------------
I'd rather deprecate current setParameter() method (all its overloaded versions).
There is getPageParameters() which can be used instead.
No need to duplicate methods.
> BookmarkablePageLink :: setParameter int versions missing
> ---------------------------------------------------------
>
> Key: WICKET-3636
> URL: https://issues.apache.org/jira/browse/WICKET-3636
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-RC3
> Reporter: Antoine van Wel
> Priority: Trivial
>
> the new URL handling & page parameters allow to use an integer index (great!)
> however this has not been implemented in BookmarkablePageLink, so this needs to be added
> private void setParameterImpl(int key, Object value)
> {
> if (parameters == null)
> {
> parameters = new PageParameters();
> }
> parameters.set(key, value);
> }
> and
> public MyBookmarkablePageLink<T> setParameter(final int property, final String value)
> {
> setParameterImpl(property, value);
> return this;
> }
> (and the same for int and long values)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira