[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7609: ui: fix notification list reordering intermittently

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #7609:
URL: https://github.com/apache/cloudstack/pull/7609#discussion_r1250588572


##########
ui/src/components/header/HeaderNotice.vue:
##########
@@ -108,8 +108,12 @@ export default {
     this.$store.watch(
       (state, getters) => getters.headerNotices,
       (newValue, oldValue) => {
-        if (oldValue !== newValue && newValue !== undefined) {
-          this.notices = newValue.reverse()
+        if (newValue !== undefined) {
+          return
+        }
+        const reversedNewValue = newValue.reverse()
+        if (oldValue !== reversedNewValue) {
+          this.notices = reversedNewValue

Review Comment:
   this feels like a bit of a stretch. Could we just check for notifications length @shwstppr ? (No new velue added should suffice, right? old values will not be removed just at a whim)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org