You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Danny Robinson (JIRA)" <de...@myfaces.apache.org> on 2007/09/21 22:20:50 UTC
[jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly
processed by plugins, switch to horzOffset/vertOffset for simplicity and
clarity.
[ https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Danny Robinson resolved TRINIDAD-731.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.0.3-core
Switched attribute names to horzOffset and vertOffset.
> xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-731
> URL: https://issues.apache.org/jira/browse/TRINIDAD-731
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.3-core
> Reporter: Danny Robinson
> Assignee: Danny Robinson
> Priority: Minor
> Fix For: 1.0.3-core
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Adam Winer <aw...@gmail.com>.
It's probably the case that the component and JSP tag methods
need to be setxOffset instead of setXOffset() - or you need to
supply a BeanInfo.
But the best and simplest option, I think, is just to rename the
properties to xoffset and yoffset, no caps - like halign and valign.
-- Adam
On 9/25/07, Danny Robinson <da...@gmail.com> wrote:
> Both.
>
> If you grab the trunk and tweak the CorePanelPopup.xml attributes back to
> using xOffset/yOffset, then also tweak findTypeConstants() in the renderer,
> then...
>
> In JSP, you get
>
> /components/panelPopup.jspx(39,102) Unable to find setter
> method for attribute: yOffset
>
> In Facelets, you get
> java.lang.ClassCastException: java.lang.String
> at
> org.apache.myfaces.trinidad.render.CoreRenderer.toInt(CoreRenderer.java:127)
> at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPopupRenderer.getHorzOffset
> (PanelPopupRenderer.java:103)
>
> as the attribute gets read, but is held internally as a String
>
> I took a look around the generated artifacts, but nothing jumps out as
> wrong.
>
> D.
>
>
> On 9/24/07, Adam Winer <aw...@gmail.com> wrote:
> > Remind me what the issue is? Is it JSP tags,
> > Facelets, both, something else?
> >
> > -- Adam
> >
> >
> > On 9/24/07, Danny Robinson <da...@gmail.com> wrote:
> > > I know. When I made the name changes, I knew the plugins should really
> get
> > > fixed ;-). Any hints on where to look in the plugins would really help
> > > (unknown territory), then I can get the attribute names reverted.
> > >
> > > D.
> > >
> > > On 9/21/07, Adam Winer <aw...@gmail.com> wrote:
> > > > Yech, why don't we just fix the plugins???
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/21/07, Danny Robinson <da...@gmail.com> wrote:
> > > > > Hard to say that they are breaking, because I'm not certain they
> ever
> > > worked
> > > > > ;-)
> > > > >
> > > > > I'll update the release notes to cover this though.
> > > > >
> > > > > D.
> > > > >
> > > > >
> > > > > On 9/21/07, Andrew Robinson < andrew.rw.robinson@gmail.com > wrote:
> > > > > > Is this a compatibility breaking change (meaning that the old
> > > > > > attributes were removed)?
> > > > > >
> > > > > > If so, were are these items documented so that users know what
> > > happened?
> > > > > >
> > > > > > -Andrew
> > > > > >
> > > > > > On 9/21/07, Danny Robinson (JIRA) < dev@myfaces.apache.org> wrote:
> > > > > > >
> > > > > > > [
> > > > >
> > >
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > > > ]
> > > > > > >
> > > > > > > Danny Robinson resolved TRINIDAD-731.
> > > > > > > -------------------------------------
> > > > > > >
> > > > > > > Resolution: Fixed
> > > > > > > Fix Version/s: 1.0.3-core
> > > > > > >
> > > > > > > Switched attribute names to horzOffset and vertOffset.
> > > > > > >
> > > > > > > > xOffset/yOffset don't get correctly processed by plugins,
> switch
> > > to
> > > > > horzOffset/vertOffset for simplicity and clarity.
> > > > > > > >
> > > > >
> > >
> ---------------------------------------------------------------------------------------------------------------------
> > > > > > > >
> > > > > > > > Key: TRINIDAD-731
> > > > > > > > URL:
> > > > > https://issues.apache.org/jira/browse/TRINIDAD-731
> > > > > > > > Project: MyFaces Trinidad
> > > > > > > > Issue Type: Improvement
> > > > > > > > Components: Components
> > > > > > > > Affects Versions: 1.0.3-core
> > > > > > > > Reporter: Danny Robinson
> > > > > > > > Assignee: Danny Robinson
> > > > > > > > Priority: Minor
> > > > > > > > Fix For: 1.0.3-core
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > This message is automatically generated by JIRA.
> > > > > > > -
> > > > > > > You can reply to this email to add a comment to the issue
> online.
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Chordiant Software Inc.
> > > > > www.chordiant.com
> > > >
> > >
> > >
> > >
> > > --
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
>
>
>
> --
>
> Chordiant Software Inc.
> www.chordiant.com
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Danny Robinson <da...@gmail.com>.
Both.
If you grab the trunk and tweak the CorePanelPopup.xml attributes back to
using xOffset/yOffset, then also tweak findTypeConstants() in the renderer,
then...
In JSP, you get
/components/panelPopup.jspx(39,102) Unable to find setter method for
attribute: yOffset
In Facelets, you get
java.lang.ClassCastException: java.lang.String
at org.apache.myfaces.trinidad.render.CoreRenderer.toInt(CoreRenderer.java
:127)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPopupRenderer.getHorzOffset
(PanelPopupRenderer.java:103)
as the attribute gets read, but is held internally as a String
I took a look around the generated artifacts, but nothing jumps out as
wrong.
D.
On 9/24/07, Adam Winer <aw...@gmail.com> wrote:
>
> Remind me what the issue is? Is it JSP tags,
> Facelets, both, something else?
>
> -- Adam
>
>
> On 9/24/07, Danny Robinson <da...@gmail.com> wrote:
> > I know. When I made the name changes, I knew the plugins should really
> get
> > fixed ;-). Any hints on where to look in the plugins would really help
> > (unknown territory), then I can get the attribute names reverted.
> >
> > D.
> >
> > On 9/21/07, Adam Winer <aw...@gmail.com> wrote:
> > > Yech, why don't we just fix the plugins???
> > >
> > > -- Adam
> > >
> > >
> > > On 9/21/07, Danny Robinson <da...@gmail.com> wrote:
> > > > Hard to say that they are breaking, because I'm not certain they
> ever
> > worked
> > > > ;-)
> > > >
> > > > I'll update the release notes to cover this though.
> > > >
> > > > D.
> > > >
> > > >
> > > > On 9/21/07, Andrew Robinson <andrew.rw.robinson@gmail.com > wrote:
> > > > > Is this a compatibility breaking change (meaning that the old
> > > > > attributes were removed)?
> > > > >
> > > > > If so, were are these items documented so that users know what
> > happened?
> > > > >
> > > > > -Andrew
> > > > >
> > > > > On 9/21/07, Danny Robinson (JIRA) < dev@myfaces.apache.org> wrote:
> > > > > >
> > > > > > [
> > > >
> >
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > > ]
> > > > > >
> > > > > > Danny Robinson resolved TRINIDAD-731.
> > > > > > -------------------------------------
> > > > > >
> > > > > > Resolution: Fixed
> > > > > > Fix Version/s: 1.0.3-core
> > > > > >
> > > > > > Switched attribute names to horzOffset and vertOffset.
> > > > > >
> > > > > > > xOffset/yOffset don't get correctly processed by plugins,
> switch
> > to
> > > > horzOffset/vertOffset for simplicity and clarity.
> > > > > > >
> > > >
> >
> ---------------------------------------------------------------------------------------------------------------------
> > > > > > >
> > > > > > > Key: TRINIDAD-731
> > > > > > > URL:
> > > > https://issues.apache.org/jira/browse/TRINIDAD-731
> > > > > > > Project: MyFaces Trinidad
> > > > > > > Issue Type: Improvement
> > > > > > > Components: Components
> > > > > > > Affects Versions: 1.0.3-core
> > > > > > > Reporter: Danny Robinson
> > > > > > > Assignee: Danny Robinson
> > > > > > > Priority: Minor
> > > > > > > Fix For: 1.0.3-core
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > This message is automatically generated by JIRA.
> > > > > > -
> > > > > > You can reply to this email to add a comment to the issue
> online.
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Chordiant Software Inc.
> > > > www.chordiant.com
> > >
> >
> >
> >
> > --
> > Chordiant Software Inc.
> > www.chordiant.com
>
--
Chordiant Software Inc.
www.chordiant.com
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Adam Winer <aw...@gmail.com>.
Remind me what the issue is? Is it JSP tags,
Facelets, both, something else?
-- Adam
On 9/24/07, Danny Robinson <da...@gmail.com> wrote:
> I know. When I made the name changes, I knew the plugins should really get
> fixed ;-). Any hints on where to look in the plugins would really help
> (unknown territory), then I can get the attribute names reverted.
>
> D.
>
> On 9/21/07, Adam Winer <aw...@gmail.com> wrote:
> > Yech, why don't we just fix the plugins???
> >
> > -- Adam
> >
> >
> > On 9/21/07, Danny Robinson <da...@gmail.com> wrote:
> > > Hard to say that they are breaking, because I'm not certain they ever
> worked
> > > ;-)
> > >
> > > I'll update the release notes to cover this though.
> > >
> > > D.
> > >
> > >
> > > On 9/21/07, Andrew Robinson <andrew.rw.robinson@gmail.com > wrote:
> > > > Is this a compatibility breaking change (meaning that the old
> > > > attributes were removed)?
> > > >
> > > > If so, were are these items documented so that users know what
> happened?
> > > >
> > > > -Andrew
> > > >
> > > > On 9/21/07, Danny Robinson (JIRA) < dev@myfaces.apache.org> wrote:
> > > > >
> > > > > [
> > >
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > ]
> > > > >
> > > > > Danny Robinson resolved TRINIDAD-731.
> > > > > -------------------------------------
> > > > >
> > > > > Resolution: Fixed
> > > > > Fix Version/s: 1.0.3-core
> > > > >
> > > > > Switched attribute names to horzOffset and vertOffset.
> > > > >
> > > > > > xOffset/yOffset don't get correctly processed by plugins, switch
> to
> > > horzOffset/vertOffset for simplicity and clarity.
> > > > > >
> > >
> ---------------------------------------------------------------------------------------------------------------------
> > > > > >
> > > > > > Key: TRINIDAD-731
> > > > > > URL:
> > > https://issues.apache.org/jira/browse/TRINIDAD-731
> > > > > > Project: MyFaces Trinidad
> > > > > > Issue Type: Improvement
> > > > > > Components: Components
> > > > > > Affects Versions: 1.0.3-core
> > > > > > Reporter: Danny Robinson
> > > > > > Assignee: Danny Robinson
> > > > > > Priority: Minor
> > > > > > Fix For: 1.0.3-core
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > This message is automatically generated by JIRA.
> > > > > -
> > > > > You can reply to this email to add a comment to the issue online.
> > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
>
>
>
> --
> Chordiant Software Inc.
> www.chordiant.com
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Danny Robinson <da...@gmail.com>.
I know. When I made the name changes, I knew the plugins should really get
fixed ;-). Any hints on where to look in the plugins would really help
(unknown territory), then I can get the attribute names reverted.
D.
On 9/21/07, Adam Winer <aw...@gmail.com> wrote:
>
> Yech, why don't we just fix the plugins???
>
> -- Adam
>
>
> On 9/21/07, Danny Robinson <da...@gmail.com> wrote:
> > Hard to say that they are breaking, because I'm not certain they ever
> worked
> > ;-)
> >
> > I'll update the release notes to cover this though.
> >
> > D.
> >
> >
> > On 9/21/07, Andrew Robinson <an...@gmail.com> wrote:
> > > Is this a compatibility breaking change (meaning that the old
> > > attributes were removed)?
> > >
> > > If so, were are these items documented so that users know what
> happened?
> > >
> > > -Andrew
> > >
> > > On 9/21/07, Danny Robinson (JIRA) < dev@myfaces.apache.org> wrote:
> > > >
> > > > [
> >
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> > > >
> > > > Danny Robinson resolved TRINIDAD-731.
> > > > -------------------------------------
> > > >
> > > > Resolution: Fixed
> > > > Fix Version/s: 1.0.3-core
> > > >
> > > > Switched attribute names to horzOffset and vertOffset.
> > > >
> > > > > xOffset/yOffset don't get correctly processed by plugins, switch
> to
> > horzOffset/vertOffset for simplicity and clarity.
> > > > >
> >
> ---------------------------------------------------------------------------------------------------------------------
> > > > >
> > > > > Key: TRINIDAD-731
> > > > > URL:
> > https://issues.apache.org/jira/browse/TRINIDAD-731
> > > > > Project: MyFaces Trinidad
> > > > > Issue Type: Improvement
> > > > > Components: Components
> > > > > Affects Versions: 1.0.3-core
> > > > > Reporter: Danny Robinson
> > > > > Assignee: Danny Robinson
> > > > > Priority: Minor
> > > > > Fix For: 1.0.3-core
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > -
> > > > You can reply to this email to add a comment to the issue online.
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Chordiant Software Inc.
> > www.chordiant.com
>
--
Chordiant Software Inc.
www.chordiant.com
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Adam Winer <aw...@gmail.com>.
Yech, why don't we just fix the plugins???
-- Adam
On 9/21/07, Danny Robinson <da...@gmail.com> wrote:
> Hard to say that they are breaking, because I'm not certain they ever worked
> ;-)
>
> I'll update the release notes to cover this though.
>
> D.
>
>
> On 9/21/07, Andrew Robinson <an...@gmail.com> wrote:
> > Is this a compatibility breaking change (meaning that the old
> > attributes were removed)?
> >
> > If so, were are these items documented so that users know what happened?
> >
> > -Andrew
> >
> > On 9/21/07, Danny Robinson (JIRA) < dev@myfaces.apache.org> wrote:
> > >
> > > [
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> > >
> > > Danny Robinson resolved TRINIDAD-731.
> > > -------------------------------------
> > >
> > > Resolution: Fixed
> > > Fix Version/s: 1.0.3-core
> > >
> > > Switched attribute names to horzOffset and vertOffset.
> > >
> > > > xOffset/yOffset don't get correctly processed by plugins, switch to
> horzOffset/vertOffset for simplicity and clarity.
> > > >
> ---------------------------------------------------------------------------------------------------------------------
> > > >
> > > > Key: TRINIDAD-731
> > > > URL:
> https://issues.apache.org/jira/browse/TRINIDAD-731
> > > > Project: MyFaces Trinidad
> > > > Issue Type: Improvement
> > > > Components: Components
> > > > Affects Versions: 1.0.3-core
> > > > Reporter: Danny Robinson
> > > > Assignee: Danny Robinson
> > > > Priority: Minor
> > > > Fix For: 1.0.3-core
> > > >
> > > >
> > >
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > You can reply to this email to add a comment to the issue online.
> > >
> > >
> >
>
>
>
> --
> Chordiant Software Inc.
> www.chordiant.com
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Danny Robinson <da...@gmail.com>.
Hard to say that they are breaking, because I'm not certain they ever worked
;-)
I'll update the release notes to cover this though.
D.
On 9/21/07, Andrew Robinson <an...@gmail.com> wrote:
>
> Is this a compatibility breaking change (meaning that the old
> attributes were removed)?
>
> If so, were are these items documented so that users know what happened?
>
> -Andrew
>
> On 9/21/07, Danny Robinson (JIRA) <de...@myfaces.apache.org> wrote:
> >
> > [
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
> >
> > Danny Robinson resolved TRINIDAD-731.
> > -------------------------------------
> >
> > Resolution: Fixed
> > Fix Version/s: 1.0.3-core
> >
> > Switched attribute names to horzOffset and vertOffset.
> >
> > > xOffset/yOffset don't get correctly processed by plugins, switch to
> horzOffset/vertOffset for simplicity and clarity.
> > >
> ---------------------------------------------------------------------------------------------------------------------
> > >
> > > Key: TRINIDAD-731
> > > URL:
> https://issues.apache.org/jira/browse/TRINIDAD-731
> > > Project: MyFaces Trinidad
> > > Issue Type: Improvement
> > > Components: Components
> > > Affects Versions: 1.0.3-core
> > > Reporter: Danny Robinson
> > > Assignee: Danny Robinson
> > > Priority: Minor
> > > Fix For: 1.0.3-core
> > >
> > >
> >
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
--
Chordiant Software Inc.
www.chordiant.com
Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
Posted by Andrew Robinson <an...@gmail.com>.
Is this a compatibility breaking change (meaning that the old
attributes were removed)?
If so, were are these items documented so that users know what happened?
-Andrew
On 9/21/07, Danny Robinson (JIRA) <de...@myfaces.apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Danny Robinson resolved TRINIDAD-731.
> -------------------------------------
>
> Resolution: Fixed
> Fix Version/s: 1.0.3-core
>
> Switched attribute names to horzOffset and vertOffset.
>
> > xOffset/yOffset don't get correctly processed by plugins, switch to horzOffset/vertOffset for simplicity and clarity.
> > ---------------------------------------------------------------------------------------------------------------------
> >
> > Key: TRINIDAD-731
> > URL: https://issues.apache.org/jira/browse/TRINIDAD-731
> > Project: MyFaces Trinidad
> > Issue Type: Improvement
> > Components: Components
> > Affects Versions: 1.0.3-core
> > Reporter: Danny Robinson
> > Assignee: Danny Robinson
> > Priority: Minor
> > Fix For: 1.0.3-core
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>