You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2022/01/01 22:55:40 UTC

[Bug 65778] New: Don't create URL from string

https://bz.apache.org/bugzilla/show_bug.cgi?id=65778

            Bug ID: 65778
           Summary: Don't create URL from string
           Product: Tomcat 9
           Version: unspecified
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: gael.lalire@gaellalire.fr
  Target Milestone: -----

At least org.apache.jasper.compiler.Compiler Tomcat creates URL from string.

Instead of transforming an URL to a string to a new URL again, it is better to
keep the original URL.

Maybe change JspServletWrapper.getDependants to Map<URL, Long> ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 65778] Don't create URL from string

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65778

Gael Lalire <ga...@gaellalire.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |---

--- Comment #2 from Gael Lalire <ga...@gaellalire.fr> ---
If you convert a URL to a string and then back to URL you will lose a specific
URLHandler.
I'm using a specific URLHandler it allows me to open, read, and verify a jar
against a checksum (sha512) once. The jar data is then kept in memory 
channel.map(MapMode.PRIVATE, 0, size), so I'm sure that tomcat parsers are
getting the signed data.

To get it working I put in the URL string something like
m2://groupid/artifactid/version so it will reopen the file from .m2/repository
but the data may not be correct.

If you want to keep other format you can create a class like this :

class URLorString {
  URL url;
  String string;

  getURL() {
    url != null ? url : new URL(string)
  }
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 65778] Don't create URL from string

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65778

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 65778] Don't create URL from string

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65778

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Not all dependencies are identified by URI. String is the lowest common
denominator. 

Also, claims that an approach is "better" needs evidence to back up that claim.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org