[GitHub] [inlong] healchow commented on a diff in pull request #5384: [INLONG-5369][Manager] Add user extended parameters to store 3rd party authentication info

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5384:
URL: https://github.com/apache/inlong/pull/5384#discussion_r939519597


##########
inlong-manager/manager-test/src/main/resources/h2/apache_inlong_manager.sql:
##########
@@ -552,6 +552,7 @@ CREATE TABLE IF NOT EXISTS `user`
     `create_time`     datetime     NOT NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'Create time',
     `modify_time`     datetime     NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'Modify time',
     `version`         int(11)      NOT NULL DEFAULT '1' COMMENT 'Version number, which will be incremented by 1 after modification',
+    `ext_params`      text         COMMENT 'Json extension info',

Review Comment:
   Suggested moving the `ext_params` before the `status` fields.



##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/UserEntity.java:
##########
@@ -46,4 +46,5 @@ public class UserEntity implements Serializable {
     private Date createTime;
     private Date modifyTime;
     private Integer version;
+    private String extParams;

Review Comment:
   Suggested moving the `extParams ` before the `status` fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org